Issue 7255 in pharo: NetNameResolver NameLookupFailure interaction if wrong

Status: New
Owner: ----
Labels: Milestone-2.0 Type-Bug

New issue 7255 by [hidden email]: NetNameResolver NameLookupFailure  
interaction if wrong
http://code.google.com/p/pharo/issues/detail?id=7255

The interaction between NetNameResolver and NameLookupFailure in case of a  
DNS failure is wrong.

The default action cannot just return nil to give up !

NameLookupFailure itself can be improved so that it can be used more  
elegantly.

Slice coming.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7255 by [hidden email]: NetNameResolver NameLookupFailure  
interaction if wrong
http://code.google.com/p/pharo/issues/detail?id=7255

In PharoInbox

Name:  
SLICE-Issue-7255-NetNameResolver-NameLookupFailure-interaction-if-wrong-SvenVanCaekenberghe.1
Author: SvenVanCaekenberghe
Time: 14 January 2013, 9:04:09.864 pm
UUID: e91cd046-207d-4c3c-8cde-2f614d8cbf8c
Ancestors:
Dependencies: Network-Kernel-SvenVanCaekenberghe.78

In NetNameResolver>>#addressForName:timeout: the signalling of  
NameLookupFailure was giving unexpected results both in the interactive as  
in the non-interactive case because NameLookupFailire>>#defaultAction did  
the wrong thing when giving up: nil was returned instead of calling super.

Cleanup NetNameResolver to bring it up to modern Exception standards and  
usage:
- added #messageText and #standardMessageText to automate the message
- added class side #signalFor: helper method
- fix the bug in #defaultAction

Simplify NetNameResolver>>#addressForName:timeout: using the above  
modifications

Slice created in #20468


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #2 on issue 7255 by [hidden email]: NetNameResolver  
NameLookupFailure interaction if wrong
http://code.google.com/p/pharo/issues/detail?id=7255

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #3 on issue 7255 by [hidden email]: NetNameResolver  
NameLookupFailure interaction if wrong
http://code.google.com/p/pharo/issues/detail?id=7255

the following still fails after integrating your slice:

ZnClient new
        numberOfRetries: 1; "0 works..."
        timeout: 5;
        url: 'http://an.url.that.does.not.exists.ch/foo';
        logToTranscript;
        downloadTo: FileSystem workingDirectory.

again Net resolver issues :/


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 7255 by [hidden email]: NetNameResolver  
NameLookupFailure interaction if wrong
http://code.google.com/p/pharo/issues/detail?id=7255

it hangs on the resolverMutex when reentering  
NetNameResolver>>#addressForName:timeout:


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 7255 by [hidden email]: NetNameResolver  
NameLookupFailure interaction if wrong
http://code.google.com/p/pharo/issues/detail?id=7255

ResolverMutex := Mutex new

solves it ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #6 on issue 7255 by [hidden email]: NetNameResolver  
NameLookupFailure interaction if wrong
http://code.google.com/p/pharo/issues/detail?id=7255

Name:  
SLICE-Issue-7255-NetNameResolver-NameLookupFailure-interaction-if-wrong-CamilloBruni.2
Author: CamilloBruni
Time: 14 January 2013, 10:18:03.634 pm
UUID: 36a6e6e3-a202-43ba-93d3-c13b772ffc24
Ancestors:  
SLICE-Issue-7255-NetNameResolver-NameLookupFailure-interaction-if-wrong-SvenVanCaekenberghe.1
Dependencies: Network-Kernel-CamilloBruni.79, Zinc-HTTP-CamilloBruni.333

use a reentrant Mutex instead of a Semaphore


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 7255 by [hidden email]: NetNameResolver  
NameLookupFailure interaction if wrong
http://code.google.com/p/pharo/issues/detail?id=7255

needs a postscript
NetNameResolver initialize


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 7255 by [hidden email]: NetNameResolver  
NameLookupFailure interaction if wrong
http://code.google.com/p/pharo/issues/detail?id=7255

Thanks a lot for looking into this !

Let's hope we got the basterd now ;-)

Did you change anything in Zinc itself ?
I can't see anything, but your slice depends on it, so I can't load it  
cleanly...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 7255 by [hidden email]: NetNameResolver  
NameLookupFailure interaction if wrong
http://code.google.com/p/pharo/issues/detail?id=7255

I'll save you the work ;-)

Name:  
SLICE-Issue-7255-NetNameResolver-NameLookupFailure-interaction-if-wrong-SvenVanCaekenberghe.2
Author: SvenVanCaekenberghe
Time: 14 January 2013, 11:00:51.903 pm
UUID: 1f6cceef-7735-4a41-8e20-cb0741f05f6a
Ancestors:  
SLICE-Issue-7255-NetNameResolver-NameLookupFailure-interaction-if-wrong-SvenVanCaekenberghe.1
Dependencies: Network-Kernel-SvenVanCaekenberghe.79

A (hopefully) cleaner slice from Camillo's bugfix:

changed NetNameResolver's ResolverMutex from
        Semaphore forMutualExclusion
to
        Mutex new
as to allow re-entry



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #10 on issue 7255 by [hidden email]: NetNameResolver  
NameLookupFailure interaction if wrong
http://code.google.com/p/pharo/issues/detail?id=7255

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #11 on issue 7255 by [hidden email]: NetNameResolver  
NameLookupFailure interaction if wrong
http://code.google.com/p/pharo/issues/detail?id=7255

in 2.0 472


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker