Issue 7269 in pharo: Code Critic automatically adds class without permission

Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Bug

New issue 7269 by [hidden email]: Code Critic automatically adds  
class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

When running the code critic via the Critic Browser (a useful tool), a  
class with a couple of class methods is added automatically, namely  
ManifestXYZ with #rejectClasses and #rejectRules, without asking for  
permission to do so.

This should be an option, IMHO.

It will confuse and scare people away...




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]
        Labels: Target-Manifest

Comment #1 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

Indeed.
Suggestion:
===========
- add settings to enable and disable manifest explicitely
- ask the first time a Manifest would be created (aka the settings is still  
uninitialized) whether the user wants this or not.
- use the settings from now on


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

Simon this goes in the direction where we can also decide to log or not  
false positive.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

I had to abandon an image because every package was marked dirty with these  
ManifestXyz classes. I was very confused as to what happened... I guess I  
had run code critic?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]
        Labels: -Type-Bug Type-FirstImpressionsCount

Comment #4 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

Can the classes be put in their own category? Making all checked packages  
dirty is a high price to pay and will discourage people from running the  
critic...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

Why this information is stored as a class ?
Can't it be some meta information attached to the concerning class  
directly ?
Or put them all in a separate package ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #6 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

Issue 7295 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

Issue 7295 was merged it is no really duplicate but Simon corrected both  
errors in the slice in inbox. The slice also contains some improvements  
about code critics.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

@bera: Oh, okay, let me take a look...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

I don't see the slice in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #11 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

Name:  
SLICE-Issue-7269-Code-Critic-automatically-adds-class-without-permission-SimonAllier.1
Author: SimonAllier
Time: 8 February 2013, 1:34:48.241 pm
UUID: 17d06d18-bf1e-43bb-821d-e19e876d98b7
Ancestors:
Dependencies: Manifest-Tests-SimonAllier.25,  
Manifest-CriticBrowser-SimonAllier.51, Manifest-Core-SimonAllier.106

When running the code critic via the Critic Browser (a useful tool), a  
class with a couple of class methods is added automatically, namely  
ManifestXYZ with #rejectClasses and #rejectRules, without asking for  
permission to do so.

This should be an option, IMHO.

It will confuse and scare people away...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

Cool, it seems to work quite nicely... Critics now runs without dirtying  
the tested packages!!! Let's let the monkey check it...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #13 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269#c13

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #14 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269#c14

Timeout occured while loading and testing the code


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #15 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

Nico and I are looking at this now


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #16 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

Nico thinks it could be nice to have atomic slices (aka slices fixing  
atomic issues)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #17 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

We commit a simple merge to see if the monkey can check this


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #18 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269#c18

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20528

Comment #19 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269#c19

This Issue has been checked by Ulysse the Monkey
       
6409 tests passed in 00:04:20s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        Manifest-Tests (25)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7269-Code-Critic-automatically-adds-class-without-permission-BenjaminVanRyseghem.2  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20528-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #20 on issue 7269 by [hidden email]: Code Critic  
automatically adds class without permission
http://code.google.com/p/pharo/issues/detail?id=7269

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker