Issue 7270 in pharo: Failing test for RPackageCategorySynchronisationTest

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 7270 in pharo: Failing test for RPackageCategorySynchronisationTest

pharo
Status: FailingTest
Owner: [hidden email]
Labels: Type-FailingTest Milestone-2.0

New issue 7270 by [hidden email]: Failing test for  
RPackageCategorySynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=7270

>>> RPackage.SystemIntegration.RPackageCategorySynchronisationTest.testRenameUnknownCategoryCreatesNewRPackage
>>> RPackage.SystemIntegration.RPackageCategorySynchronisationTest.testRenameCategoryChangeTheNameOfThePackage
>>> RPackage.SystemIntegration.RPackageCategorySynchronisationTest.testRenameCategoryUpdateTheOrganizer
>>> RPackage.SystemIntegration.RPackageCategorySynchronisationTest.testRenameCategoryAlsoRenameAllExtensionProtocols



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7270 in pharo: Failing test for RPackageCategorySynchronisationTest

pharo
Updates:
        Labels: Target-RPackage

Comment #1 on issue 7270 by [hidden email]: Failing test for  
RPackageCategorySynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=7270

nasty, if you run these tests the whole RPackage structure is messed up.
I tried to remove the halt from  
RPackageOrganizer>>systemCategoryRenamedActionFrom: after running the tests  
but RPackageOrganizer is no longer in a proper package.
Furthermore Monticello does not show me that the package has been  
modified :/


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7270 in pharo: Failing test for RPackageCategorySynchronisationTest

pharo
Updates:
        Cc: [hidden email]

Comment #2 on issue 7270 by [hidden email]: Failing test for  
RPackageCategorySynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=7270

I cannot reproduce it in my system. Any idea?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7270 in pharo: Failing test for RPackageCategorySynchronisationTest

pharo

Comment #3 on issue 7270 by [hidden email]: Failing test for  
RPackageCategorySynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=7270

I think this is because we run the tests twice.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7270 in pharo: Failing test for RPackageCategorySynchronisationTest

pharo

Comment #4 on issue 7270 by [hidden email]: Failing test for  
RPackageCategorySynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=7270

did you try to use the serialized stack on the test servers? (that is to  
figure out why they fail in the first place, and not the problem I  
described above)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7270 in pharo: Failing test for RPackageCategorySynchronisationTest

pharo
Updates:
        Labels: sprintChile

Comment #5 on issue 7270 by [hidden email]: Failing test for  
RPackageCategorySynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=7270

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7270 in pharo: Failing test for RPackageCategorySynchronisationTest

pharo

Comment #6 on issue 7270 by [hidden email]: Failing test for  
RPackageCategorySynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=7270

The problem in:

>>> RPackage.SystemIntegration.RPackageCategorySynchronisationTest.testRenameCategoryAlsoRenameAllExtensionProtocol

is that in: RPackageOrganizer >> systemCategoryRenamedActionFrom:, in the  
line classesAndProtocolsToRename := rPackage extensionMethods asSet., when  
converting to a set, one of the elements of the list(of class  
CompiledMethod) is removed, because the two of them are "equal", even  
though their literals are different. The fix is to change this line to  
convert to an IdentitySet. We also removed the self halt.

(Fix in  
SLICE-Issue-7270-Failing-test-for-RPackageCategorySynchronisationTest-EstebanAllende.1)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7270 in pharo: Failing test for RPackageCategorySynchronisationTest

pharo
In reply to this post by pharo
Updates:
        Status: FixReviewNeeded
        Labels: --

Comment #8 on issue 7270 by [hidden email]: Failing test for  
RPackageCategorySynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=7270

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7270 in pharo: Failing test for RPackageCategorySynchronisationTest

pharo

Comment #9 on issue 7270 by [hidden email]: Failing test for  
RPackageCategorySynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=7270

Issue 7362 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7270 in pharo: Failing test for RPackageCategorySynchronisationTest

pharo
Updates:
        Status: FixToInclude

Comment #10 on issue 7270 by [hidden email]: Failing test for  
RPackageCategorySynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=7270

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7270 in pharo: Failing test for RPackageCategorySynchronisationTest

pharo
Updates:
        Status: Integrated

Comment #11 on issue 7270 by [hidden email]: Failing test for  
RPackageCategorySynchronisationTest
http://code.google.com/p/pharo/issues/detail?id=7270

in 2.0 506


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker