Issue 7277 in pharo: inspectOnce is not working anymore

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 7277 in pharo: inspectOnce is not working anymore

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Importance-Low Milestone-2.0 Difficulty-Easy

New issue 7277 by [hidden email]: inspectOnce is not working anymore
http://code.google.com/p/pharo/issues/detail?id=7277

inspectOnce
        "Inspect unless we have already done it once."
        self haltOnceEnabled
                ifTrue: [self clearHaltOnce.
                                ^ self inspect]

and haltOnceEnabled and clearHaltOnce are not implemented on Object but  
Halt.
In addition probably using ensure: may be better.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7277 in pharo: inspectOnce is not working anymore

pharo
Updates:
        Cc: [hidden email]

Comment #1 on issue 7277 by [hidden email]: inspectOnce is not  
working anymore
http://code.google.com/p/pharo/issues/detail?id=7277

Same for inspectUntilCount:

and hasHaltCount seems to be not in the image anymore.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7277 in pharo: inspectOnce is not working anymore

pharo
Updates:
        Status: FixReviewNeeded

Comment #2 on issue 7277 by [hidden email]: inspectOnce is not  
working anymore
http://code.google.com/p/pharo/issues/detail?id=7277

Fixed... and I threw in #inspectOnCount:, but see slice comment below...

Fix in inbox:  
SLICE-Issue-7277-inspectOnce-is-not-working-anymore-SeanDeNigris.1

- Make Object>>inspectOnce, inspectUntilCount:, and inspectOnCount:  
delegate to Halt

Even though they now work as before, I think these are all fundamentally  
flawed. Why are they using the global variable from Halt? If I have a Halt  
once somewhere, and an inspectOnCount: somewhere else, why should they not  
be able to co-exist? Is it obvious from the user perspective that there  
would be a conflict?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7277 in pharo: inspectOnce is not working anymore

pharo

Comment #3 on issue 7277 by [hidden email]: inspectOnce is not  
working anymore
http://code.google.com/p/pharo/issues/detail?id=7277

A little snippet for testing...

Halt enableHaltOnce.
(1 to: 5) do: [ :e |
        Transcript show: e; cr.
        e inspectOnCount: 1.
]


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7277 in pharo: inspectOnce is not working anymore

pharo

Comment #4 on issue 7277 by [hidden email]: inspectOnce is not  
working anymore
http://code.google.com/p/pharo/issues/detail?id=7277

can't the implementation be all in Halt, with Object just forwarding


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7277 in pharo: inspectOnce is not working anymore

pharo
Updates:
        Cc: [hidden email]

Comment #5 on issue 7277 by [hidden email]: inspectOnce is not  
working anymore
http://code.google.com/p/pharo/issues/detail?id=7277

@marcus: I guess the implementation could be in Halt, but what does  
inspection really have to do with halting? I want do decouple from halt.  
I'm tempted to write another small class, but what could it be called?  
ConditionalInspector? with forwarding methods in Object?

Object>>inspectOn: anInteger
     ConditionalInspector openOn: self onCount: anInteger


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7277 in pharo: inspectOnce is not working anymore

pharo
Updates:
        Status: FixToInclude

Comment #6 on issue 7277 by [hidden email]: inspectOnce is not  
working anymore
http://code.google.com/p/pharo/issues/detail?id=7277

ah, ok, lets then add it like this.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7277 in pharo: inspectOnce is not working anymore

pharo
Updates:
        Status: Integrated

Comment #7 on issue 7277 by [hidden email]: inspectOnce is not  
working anymore
http://code.google.com/p/pharo/issues/detail?id=7277

in 2.0 487


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker