Issue 7284 in pharo: Cannot run gofer load twice => Error: cannot remove non empty category

Status: New
Owner: ----
CC: [hidden email]
Labels: Milestone-2.0 Type-Bug

New issue 7284 by [hidden email]: Cannot run gofer load twice =>  
Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284

With the latest pharo2 image, I cannot load twice a package without getting  
the error : "cannot remove non empty category".
Is it an issue related to rpackage?

Here is the code to reproduce the bug:
----------------

| gofer repo configClassName |
"we need to load Versionner-Tests-Resources "
Gofer new
     squeaksource3: 'Versionner';
     package: 'Versionner-Tests-Resources';
     load.

gofer := Gofer new.
repo := (Smalltalk globals at: #MBMonticelloPackagesResource) current  
monticelloRepository.
gofer repository: repo.
       
"load configuration"
configClassName := #ConfigurationOfMBFooTests.
gofer version: 'ConfigurationOfMBFooTests-dkh.3'.
gofer load.
       
gofer load.
----------------------
Without the last line, no problem.

Thanks for your help.

Regards,
Christophe.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284

Christophe could you build a smaller test so that we can identify the  
problem?
Thanks
Is this problem happen with any packages that we load two times?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284

This problem does not happen with any package.
This example is quite small (loading a configuration claa, configuring  
gofer and loading twice). Do you mean try to have the same problem with a  
configuration with less dependencies?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: sprintchile

Comment #3 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284

We have found 2 posibles causes for this issue:

1. The method MCOrganizationDefinition>>unload just use the removeCategory:  
and this method dont delete the classes inside the category and raise an  
error:
     MCOrganizationDefinition>>unload
     categories do: [ :c | SystemOrganization removeCategory:         c ].
A possible solution for this could be use the removeSystemCategory:  
instead, since it delete the classes inside and then the category.
     MCOrganizationDefinition>>unload
     categories do: [ :c | SystemOrganization removeSystemCategory:          
c ].

It's removing the classes inside the category what we really want to do?  
There is a reason for not deleting the classes inside?

2. We track the criteria for deleting packages on the clean up of the  
PackageLoader and we got to:
The reason that some packages has this issue it is that some of them need  
to remove some categories
The most strange thing now is that in some cases, when we load the same  
version that the system already had, it generates diferent base and target  
snapshots definitions.
     MCPatch>>initializeWithBase: baseSnapshot target: targetSnapshot
     | base target |
     operations := OrderedCollection new.
     base := MCDefinitionIndex definitions: baseSnapshot definitions.
     target := MCDefinitionIndex definitions: targetSnapshot definitions.

     ...
     base definitions do:
         [:b |
         target
             definitionLike: b
             ifPresent: [:t]
             ifAbsent: [operations add: (MCRemoval of: b)]]

This is clearly happening with the code provided for reproducing the bug by  
Christophe.

Another code that reproduce the bug is the following:
Gofer new
  squeaksource: 'Roassal';
        package: 'ConfigurationOfRoassal';
        load.
((Smalltalk at: #ConfigurationOfRoassal) project version: '1.200') load.
((Smalltalk at: #ConfigurationOfRoassal) project version: '1.269') load.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #6 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284

esteban we will have to look at it because this touching internal of MC and  
we should decide the logic we want.
For the first point: removing the classes makes sense to me.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #7 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284#c7

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20498

Comment #8 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284#c8

This Issue has been checked by Ulysse the Monkey
       
6506 tests passed in 00:03:10s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (589)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Monticello (127)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7284-Cannot-run-gofer-load-twice-gt-Error-cannot-remove-non-empty-category-JuanPabloSandovalA.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20498-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.166 uuid:  
5773fcb9-2982-4507-8a9e-4308ec33731e Dec 12 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.166 uuid:  
5773fcb9-2982-4507-8a9e-4308ec33731e Dec 12 2012
git://gitorious.org/cogvm/blessed.git Commit:  
452863bdfba2ba0b188e7b172e9bc597a2caa928 Date: 2012-12-07 16:49:46 +0100  
By: Esteban Lorenzano <[hidden email]> Jenkins build #5922


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #9 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284#c9

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20499

Comment #10 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284#c10

This Issue has been checked by Ulysse the Monkey
       
6510 tests passed in 00:03:10s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Monticello (127)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7284-Cannot-run-gofer-load-twice-gt-Error-cannot-remove-non-empty-category-JuanPabloSandovalA.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20499-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.166 uuid:  
5773fcb9-2982-4507-8a9e-4308ec33731e Dec 12 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.166 uuid:  
5773fcb9-2982-4507-8a9e-4308ec33731e Dec 12 2012
git://gitorious.org/cogvm/blessed.git Commit:  
452863bdfba2ba0b188e7b172e9bc597a2caa928 Date: 2012-12-07 16:49:46 +0100  
By: Esteban Lorenzano <[hidden email]> Jenkins build #5922


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #11 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284#c11

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20500

Comment #12 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284#c12

This Issue has been checked by Ulysse the Monkey
       
6510 tests passed in 00:02:36s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Monticello (127)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7284-Cannot-run-gofer-load-twice-gt-Error-cannot-remove-non-empty-category-JuanPabloSandovalA.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20500-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284

esteban monday we should talk about this bug face to face :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284

ha... ok :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #15 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284#c15

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20507

Comment #16 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284#c16

This Issue has been checked by Ulysse the Monkey
       
6511 tests passed in 00:01:44s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Monticello (127)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7284-Cannot-run-gofer-load-twice-gt-Error-cannot-remove-non-empty-category-JuanPabloSandovalA.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20507-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #17 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284#c17

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20509

Comment #18 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284#c18

This Issue has been checked by Ulysse the Monkey
       
6511 tests passed in 00:01:39s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Monticello (127)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7284-Cannot-run-gofer-load-twice-gt-Error-cannot-remove-non-empty-category-JuanPabloSandovalA.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20509-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #19 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284#c19

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20510

Comment #20 on issue 7284 by [hidden email]: Cannot run gofer load  
twice => Error: cannot remove non empty category
http://code.google.com/p/pharo/issues/detail?id=7284#c20

This Issue has been checked by Ulysse the Monkey
       
6511 tests passed in 00:01:31s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Monticello (127)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7284-Cannot-run-gofer-load-twice-gt-Error-cannot-remove-non-empty-category-JuanPabloSandovalA.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20510-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker