Issue 7292 in pharo: Autocomplete partial matches

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
24 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Issue 7292 in pharo: Autocomplete partial matches

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Enh

New issue 7292 by [hidden email]: Autocomplete partial matches
http://code.google.com/p/pharo/issues/detail?id=7292

There is a bash feature that's SO useful. Say there are only three files in  
the current dir:
abc1
abc2
abc3

If you type a [tab], bash autocompletes the part that has been definitely  
matched, so "abc", then you just have to type 1 | 2 | 3.

One example where this comes into play in a BIG way in Pharo is with  
ConfigurationOfXxxs. The autocomplete menu is nearly useless because it  
lists every config in the system, which only differ in the last part.

With the above feature, in my current image, to complete  
ConfigurationOfPhexample, you'd just have to type Con [tab] P [tab].


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo

Comment #1 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

=> check the completion settings: "Complete common prefixes using TAB in  
the suggested completions"

I added it a while ago, it is still a bit buggy, but does the job ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
Updates:
        Status: FixReviewNeeded
        Cc: [hidden email]
        Labels: Difficulty-Easy

Comment #2 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

@cami: Document, damn you!! ;) j/k... I've been toiling away typing  
unnecessary keystrokes while you were hoarding this awesome feature!! I  
improved it a bit...

To test slice:
1. Open Spotlight
2. Type "Con"
3. Hit tab... nothing will happen bc there is no common prefix
4. Type "f"
5. Hit tab... it will complete to "Configuration"
6. Hit tab... nothing will happen bc there is no common prefix
7. Type "O"
8. Hit tab... it will complete to "ConfigurationOf"

Fix in inbox: SLICE-Issue-7292-Autocomplete-partial-matches-SeanDeNigris.1

- Fix bug in which first entry would be completed if next two entries begin  
with entry 1
- Fix bug where tab would be inserted into editor if no partial matches  
were possible; more generally, input was not being declared as handled,  
even if the partial match logic handled it
- Clean and simplify partial matching logic
- Compare common prefix against the controller's model instead of the  
context, which gets out of sync with the editor after a partial completion  
(a separate issue will be opened for the syncing issue)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
In reply to this post by pharo
Issue 7292: Autocomplete partial matches
http://code.google.com/p/pharo/issues/detail?id=7292

This issue is now blocking issue pharo:7308.
See http://code.google.com/p/pharo/issues/detail?id=7308

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
In reply to this post by pharo

Comment #4 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

New slice in inbox:  
SLICE-Issue-7292-Autocomplete-partial-matches-SeanDeNigris.2

- Fix DNU when first completion suggestion does not share a common prefix  
with any other suggestion from the menu e.g. the following completion menu:
        - ConfigurationOfMonticello
        - MyConfigurationOfMonticello


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo

Comment #5 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

love to see progress!
Hope to test it next week!!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
Updates:
        Status: HumanReviewNeeded

Comment #6 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

All NEC tests pass


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
Updates:
        Labels: Milestone-2.0

Comment #7 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
Updates:
        Status: FixToInclude

Comment #8 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

cool :)

but still completion is severely broken.. it does not helps at all (it  
shows just a bunch of symbols, no necesarily existing in system or useful..  
like for example type "20", new completion will show all timestamps for  
methods that starts in this cycle...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
Updates:
        Status: Integrated

Comment #9 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

in 20485


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
Updates:
        Cc: [hidden email]

Comment #10 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

@esteban: "new completion will show all timestamps for methods that starts  
in this cycle..."
ouch!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
Updates:
        Status: QualityControl

Comment #11 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

Sean, this needs a bit of care... it is behaving a bit weird.

Sometimes it introduces an enter, or put a complete string if I press tab  
(instead just complete), and it is breaking "enter" to select.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo

Comment #12 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

@esteban: I really like this feature. I'm willing to make sure it comes out  
right. How do I reproduce the bugs you're seeing?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo

Comment #13 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

@esteban: I found one bug... slice incoming... Issue 7330: [BUG]:  
Autocomplete "use enter to accept" broken


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
Updates:
        Status: WorkNeeded-NextAction
        Labels: -Type-Enh -Difficulty-Easy Type-FirstImpressionsCount

Comment #14 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo

Comment #15 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

Sean, here a description of what else is happening:

start complete Object in workspace, press Obj then space... Object is  
completed, then down arrow to ObjectExplorer and press enter to complete it  
(I have configured accept with enter)... you will see

ObjObjectExplorer

As the completion :(



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
Updates:
        Status: FixReviewNeeded
        Labels: Difficulty-Easy

Comment #16 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292

Fix in inbox: SLICE-Issue-7292-Autocomplete-partial-matches-SeanDeNigris.3

- Call #narrowWith: on context after a partial match

n.b. I feel like that might be better happening in #insertCompletion: -  
won't you always want to #narrowWith: after an insertion, whether partial  
or otherwise? But this fixes the immediate problem


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
Updates:
        Status: MonkeyIsChecking

Comment #17 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292#c17

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20514

Comment #18 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292#c18

This Issue has been checked by Ulysse the Monkey
       
6447 tests passed in 00:01:19s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        NECompletion-Tests (63)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source: SLICE-Issue-7292-Autocomplete-partial-matches-SeanDeNigris.3  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20514-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7292 in pharo: Autocomplete partial matches

pharo
Updates:
        Status: MonkeyIsChecking

Comment #19 on issue 7292 by [hidden email]: Autocomplete partial  
matches
http://code.google.com/p/pharo/issues/detail?id=7292#c19

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
12