Issue 7293 in pharo: [BUG]: Spotlight should handle packages

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 7293 by [hidden email]: [BUG]: Spotlight should handle  
packages
http://code.google.com/p/pharo/issues/detail?id=7293

Pharo2.0a
Latest update: #20476

Package names appear in the autocomplete menu, but when selected, we only  
get a growl notification that there is no such class


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #1 on issue 7293 by [hidden email]: [BUG]: Spotlight should  
handle packages
http://code.google.com/p/pharo/issues/detail?id=7293

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 7293 by [hidden email]: [BUG]: Spotlight should  
handle packages
http://code.google.com/p/pharo/issues/detail?id=7293

One wrinkle would be when there is a package and class with the same  
name... although that's already an issue between classes and selectors, so  
it's not any worse that the current situation...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7293 by [hidden email]: [BUG]: Spotlight should  
handle packages
http://code.google.com/p/pharo/issues/detail?id=7293

Oh, I see, Spotlight assumes that selectors can only be lowercase. Mac's  
spotlight breaks results down into types, but I guess that would be a lot  
more work, making a custom morph, for a fairly uncommon edge case... which  
would equally apply to packages.

Possible other solutions:
1. put the type in the menu entry e.g. "Morphic (package)"
2. Remove packages from the completion list - although I think browsing a  
package is a fairly common and useful operation...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 7293 by [hidden email]: [BUG]: Spotlight should  
handle packages
http://code.google.com/p/pharo/issues/detail?id=7293

What really happens is that so far, Spotlight relies in NewOCompletion,  
which is severely broken... I will trty to fix it or to come back to the  
older implementation before release :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 7293 by [hidden email]: [BUG]: Spotlight should  
handle packages
http://code.google.com/p/pharo/issues/detail?id=7293

and btw... someone changed default completion from NOCompletion to  
NECompletion.
no idea why, but anyway... personally I think NOC is a lot better than the  
older... but it also need some improvements.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: sprintChile

Comment #6 on issue 7293 by [hidden email]: [BUG]: Spotlight should  
handle packages
http://code.google.com/p/pharo/issues/detail?id=7293

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #8 on issue 7293 by [hidden email]: [BUG]: Spotlight should  
handle packages
http://code.google.com/p/pharo/issues/detail?id=7293

in inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #9 on issue 7293 by [hidden email]: [BUG]: Spotlight should  
handle packages
http://code.google.com/p/pharo/issues/detail?id=7293#c9

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20529

Comment #10 on issue 7293 by [hidden email]: [BUG]: Spotlight should  
handle packages
http://code.google.com/p/pharo/issues/detail?id=7293#c10

This Issue has been checked by Ulysse the Monkey
       
6414 tests passed in 00:01:33s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        ToolsTest-Base (2)
        ToolsTest-Debugger (10)
        ToolsTest-Finder (9)
        ToolsTest-Inspector (1)
        ToolsTest-MessageTally (5)
        ToolsTest-PointerFinder (3)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7293-BUG-Spotlight-should-handle-packages-EstebanLorenzano.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20529-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #11 on issue 7293 by [hidden email]: [BUG]: Spotlight should  
handle packages
http://code.google.com/p/pharo/issues/detail?id=7293

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #12 on issue 7293 by [hidden email]: [BUG]: Spotlight should  
handle packages
http://code.google.com/p/pharo/issues/detail?id=7293

in 2.0 530


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker