Issue 7308 in pharo: [BUG]: Autocomplete highlighting out of sync w editor after partial match

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 7308 in pharo: [BUG]: Autocomplete highlighting out of sync w editor after partial match

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Bug

New issue 7308 by [hidden email]: [BUG]: Autocomplete highlighting  
out of sync w editor after partial match
http://code.google.com/p/pharo/issues/detail?id=7308

- Compare common prefix against the controller's model instead of the  
context, which gets out of sync with the editor after a partial completion  
(a separate issue will be opened for the syncing issue)

  the only bug I see now is when you do multiple completions, the NECContext  
gets out of sync with the editor, because it's never had to stay in sync  
before partial completions

Steps to reproduce:
1. Enable partial completion
2. Open Spotlight
3. Type "Conf"
4. Hit tab to complete partially to "Configuration"

You'll notice that the partial completion happened, but the highlighting in  
the completion menu did not update

IIRC, the NEC context is the thing that has to be updated after a partial  
match


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7308 in pharo: [BUG]: Autocomplete highlighting out of sync w editor after partial match

pharo

Comment #1 on issue 7308 by [hidden email]: [BUG]: Autocomplete  
highlighting out of sync w editor after partial match
http://code.google.com/p/pharo/issues/detail?id=7308

This issue will be relevant after the enhancements to partial autocomplete  
in Issue 7292 are integrated


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7308 in pharo: [BUG]: Autocomplete highlighting out of sync w editor after partial match

pharo

Comment #2 on issue 7308 by [hidden email]: [BUG]: Autocomplete  
highlighting out of sync w editor after partial match
http://code.google.com/p/pharo/issues/detail?id=7308

As part of the fix for this, include a change to  
NECMenuMorph>>insertCommonPrefix, which is described in a #flag: in that  
method:
...
        self flag: 'Pending issue 7308, "controller editor wordAtCaret" below  
should be changed to "context completionToken"'.
        prefix size > controller editor wordAtCaret size
...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker