Status: Accepted
Owner: [hidden email] Labels: Type-Bug Milestone-2.0 New issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 Frankly I fixed it by modifying the refresh method (where the problem was detected by opening the PharoTaskForces repository. Then after it brokes because loaded was nil. Now I cannot understand except a concurrency issue because loaded was only set in the refresh method. So I added an initialize method to initialize loaded to an empty set and it works. Probably that some changes were made to fork the get of the list and ... it just worked because the concurrency was nice with us. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #1 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 when I see code like that ... this is clear that having a MCName would clean massively this code. av := ((ancestor name copyAfterLast: $-) copyAfter: $.) asInteger. av < latest third or: [ av = latest third and: [ ((ancestor name copyAfterLast: $-) copyUpTo: $.) ~= latest second _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixToInclude Comment #2 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 change in the inbox _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: WontFix Comment #3 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 in 2.0 485 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixToInclude Comment #4 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 No, had to revert because of a wrong update _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #5 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 what do you mean a wrong update? _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #6 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 I did a batch (tried to do a batch) of updates, one made it fail, I did not publish that uodate but already close the rreport, so I had to open it again. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #7 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 Ok Apparently this is readableFileNames that I should improve because Moose has problem with it. So I will propose a new fix. readableFileNames | all cached new | all := self allFileNames. "from repository" cached := self cachedFileNames. "in memory" new := all difference: cached. ^ (cached asArray, new) select: [:ea | self canReadFileNamed: ea] _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Cc: [hidden email] Comment #8 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 I submitted another slice which should fix the problem of doru. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: WorkNeeded Comment #9 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 Apparently this introduces some side effects I'm trying to understand. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #10 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 I think taht this is because I'm trying 2.0 code on 1.4. So this fix can be probably loaded in 2.0 and I will redo it in 1.4 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixToInclude Comment #11 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 Doru here is the change for 1.4 MCFileBasedRepository>>readableFileNames | all cached new emptyFilenamelength | emptyFilenamelength := 'P-i.c.mcz' size. all := self allFileNamesOrCache. "from repository" all := all reject: [ :each | each size < emptyFilenamelength]. "first stupid way to filter first level broken files. Ideally we should remove any files not following the naming pattern: PackageName-author.number[(branch)].mcz" cached := self cachedFileNames. "in memory" new := all difference: cached. ^ (cached asArray, new) select: [:ea | self canReadFileNamed: ea] _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #12 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 Thanks a lot, Stef. I am full time busy today, but I will look at it at the latest on Monday. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Integrated Comment #13 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 in 20488 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #14 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 I looked at the fix for 1.4 and it works fine. Thanks! _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Labels: 1.4 Comment #15 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 Ok cool. We pushed the other on _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #16 on issue 7311 by [hidden email]: making MCfileInspector more robust to broken files http://code.google.com/p/pharo/issues/detail?id=7311 Good we pushed the other one in 2.0 So I will continue to work today on the realoder _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Free forum by Nabble | Edit this page |