Issue 7328 in pharo: diffmorph does not shows the middle separator

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 7328 in pharo: diffmorph does not shows the middle separator

pharo
Status: QualityControl
Owner: ----
Labels: Milestone-2.0 Type-Bug

New issue 7328 by [hidden email]: diffmorph does not shows the middle  
separator
http://code.google.com/p/pharo/issues/detail?id=7328

and it looks ugly.

thats because before, diffmorph had grey background for text panels and  
separator was white, now text panels are white too, so nobody can see the  
divisor.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7328 in pharo: diffmorph does not shows the middle separator

pharo
Updates:
        Owner: [hidden email]

Comment #1 on issue 7328 by [hidden email]: diffmorph does not shows  
the middle separator
http://code.google.com/p/pharo/issues/detail?id=7328

This is because the normal splitter fill style of PharoTheme is  
transparent. It only appears when clicked. Looking at Mac finder, I don't  
think visual feedback is so important, since we already have the cursor  
change. Slice incoming that keeps splitters visible at all times...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7328 in pharo: diffmorph does not shows the middle separator

pharo
Updates:
        Status: HumanReviewNeeded
        Cc: [hidden email]

Comment #2 on issue 7328 by [hidden email]: diffmorph does not shows  
the middle separator
http://code.google.com/p/pharo/issues/detail?id=7328

Fix in inbox:  
SLICE-Issue-7328-diffmorph-does-not-shows-the-middle-separator-SeanDeNigris.1

- change PharoTheme to keep splitters visible even when not being clicked


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7328 in pharo: diffmorph does not shows the middle separator

pharo

Comment #3 on issue 7328 by [hidden email]: diffmorph does not shows  
the middle separator
http://code.google.com/p/pharo/issues/detail?id=7328

Ok I will have a look and integrate this change.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7328 in pharo: diffmorph does not shows the middle separator

pharo

Comment #4 on issue 7328 by [hidden email]: diffmorph does not shows  
the middle separator
http://code.google.com/p/pharo/issues/detail?id=7328

Sean I see that you use GlamourousBaseColor: and I wonder the implication.
But apparently it was already like that :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7328 in pharo: diffmorph does not shows the middle separator

pharo

Comment #5 on issue 7328 by [hidden email]: diffmorph does not shows  
the middle separator
http://code.google.com/p/pharo/issues/detail?id=7328

Integrated in 20496


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7328 in pharo: diffmorph does not shows the middle separator

pharo
Updates:
        Cc: [hidden email]

Comment #6 on issue 7328 by [hidden email]: diffmorph does not shows  
the middle separator
http://code.google.com/p/pharo/issues/detail?id=7328

Re Glamour, yes it was like that already. I just copied the code  
from "splitter pressed" or whatever to "splitter normal"


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7328 in pharo: diffmorph does not shows the middle separator

pharo
Updates:
        Status: Integrated

Comment #7 on issue 7328 by [hidden email]: diffmorph does not shows  
the middle separator
http://code.google.com/p/pharo/issues/detail?id=7328

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker