Issue 7345 in pharo: DNU with Glamour: PaginatedMorphTreeMorph>>setSelectedMorph:

Status: New
Owner: ----
Labels: Milestone-1.4 Type-Bug

New issue 7345 by [hidden email]: DNU with Glamour:  
PaginatedMorphTreeMorph>>setSelectedMorph:
http://code.google.com/p/pharo/issues/detail?id=7345

In glamour,  the rendering of ListPresentation raises an error when setting  
the selection to a value outside of the visible elements. The problem  
raised is:
MessageNotUnderstood: PaginatedMorphTreeMorph>>setSelectedMorph:

To reproduce the error, this script can be executed in an image containing  
glamour packages:

        | browser items |
        browser := GLMTabulator withStatusbar.
        browser column: #one; column: #two.
        browser transmit to: #one; andShow: [ :a |
                a tree showOnly: 30 ].
        window := browser openOn: (1 to: 100).
       
   ((browser paneNamed: #one) port:#selection) value: 40.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7345 by [hidden email]: DNU with Glamour:  
PaginatedMorphTreeMorph>>setSelectedMorph:
http://code.google.com/p/pharo/issues/detail?id=7345

Slice in inbox

For the work done with Usman during the last Pharo sprint...

Changed the #openItemPath in PaginatedMorphTreeMorph update to take in  
account the item we are trying to open may not be present.
Added a currentPage: to make sure all pagers select the correct page before  
trying to select an item.
Corrected a bug in index to page translation.
Corrected a bug in the way MorphTreeChunkPager was adding new morphs to the  
tree.
Added an example and two test cases.

There is an additional change to do in Glamour, to select a MorphTreePager  
instead of a MorphTreeChunkPager. If, in a PaginatedMorphTreeMorph, we use  
chunkSize: first, a MorphTreeChunkPager is used, if we use pageSize: first,  
then a MorphTreePager is used. The change in Glamour is to remove the call  
to chunkSize:.

The Chunk pager page from 1 to the chosen element; the normal pager handles  
really page by page. I suspect the chunk pager would not work well with a  
very large collection of items.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded
        Labels: Milestone-2.0

Comment #2 on issue 7345 by [hidden email]: DNU with Glamour:  
PaginatedMorphTreeMorph>>setSelectedMorph:
http://code.google.com/p/pharo/issues/detail?id=7345

so that we can sell product with Pharo :)
Usman can you try and let us know


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7345 by [hidden email]: DNU with Glamour:  
PaginatedMorphTreeMorph>>setSelectedMorph:
http://code.google.com/p/pharo/issues/detail?id=7345

Hi Stef,

For a interesting test on this slice, try this and tell me if it's fast  
enough :)

        | treeMorph aWindow aModel |
        aModel := PaginatedMorphTreeModel itemsList: (1 to: 10000) asArray.
        aWindow := aModel theme newWindowIn: World for: aModel title: 'test'.
        treeMorph := aModel defaultTreeMorph.
        treeMorph pageSize: 30.
        treeMorph buildContents.
        aWindow addMorph: treeMorph fullFrame: (LayoutFrame fractions: (0 @ 0  
corner: 1 @ 1) offsets: (0 @ 0 corner: 0 @ 0)).
        aWindow open.
        aModel changed: #(#rootNodes #openItemPath 9980).

This is close to the test done by Usman with his image...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #5 on issue 7345 by [hidden email]: DNU with Glamour:  
PaginatedMorphTreeMorph>>setSelectedMorph:
http://code.google.com/p/pharo/issues/detail?id=7345

in 2.0 534


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 7345 by [hidden email]: DNU with Glamour:  
PaginatedMorphTreeMorph>>setSelectedMorph:
http://code.google.com/p/pharo/issues/detail?id=7345

It works for me in Glamour, the bug is fixed. I tried with 16K nodes and  
there is no performance issue so this is great! So we can integrate this in  
Pharo. There is a fix for glamour so I'll communicate it to Doru.
Tx a lot Thierry.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 7345 by [hidden email]: DNU with Glamour:  
PaginatedMorphTreeMorph>>setSelectedMorph:
http://code.google.com/p/pharo/issues/detail?id=7345

I've been happy to be of help :)

I allways wondered if that paging code was working, and you gave me a good  
excuse to have a look in it... It got me thinking if I could do some  
caching in List and Tree type morphs in a different way.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker