Issue 7367 in pharo: Add support for Phexample to Nautilus and cleanup testing for test methods a bit

Status: New
Owner: ----
Labels: Milestone-2.0 Type-Feature Target-Nautilus Difficulty-Easy

New issue 7367 by [hidden email]: Add support for Phexample to Nautilus  
and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

A simple change to make sure that methods that start with 'should' are  
treated the same as 'test*' methods.

I also tried to use the #isTestMethod of Nautilus more consistently.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7367 by [hidden email]: Add support for Phexample to  
Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

I put a slice in the inbox.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #2 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #3 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367#c3

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #4 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367#c4

Timeout occured while loading and testing the code


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #5 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #6 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367#c6

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #7 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367#c7

Timeout occured while loading and testing the code


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

The reason is that there is a conlfict... easy to sovlve, I submit a new  
slice


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #9 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

Name:  
SLICE-Issue-7367-Add-support-for-Phexample-to-Nautilus-and-cleanup-testing-for-test-methods-a-bit-MarcusDenker.2
Author: MarcusDenker
Time: 5 February 2013, 4:22:40.542 pm
UUID: 40550316-6e3c-42ec-8f9d-87a10dc655d5
Ancestors:  
SLICE-Issue-7367-Add-support-for-Phexample-to-Nautilus-and-cleanup-testing-for-test-methods-a-bit-StefanMarr.1
Dependencies: Nautilus-MarcusDenker.410, NautilusCommon-MarcusDenker.112

- fix conflict
- fix isTestMethod in Ring, too


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #10 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367#c10

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20514

Comment #11 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367#c11

This Issue has been checked by Ulysse the Monkey
       
6392 tests passed in 00:01:22s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        Nautilus-Tests (8)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7367-Add-support-for-Phexample-to-Nautilus-and-cleanup-testing-for-test-methods-a-bit-MarcusDenker.2  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20514-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude
        Cc: [hidden email]

Comment #12 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

It seems to work... although the TestRunner still doesn't pick shouldXyz  
methods up.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 7367 by [hidden email]: Add support for Phexample to  
Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

Sean, you need to have loaded Phexample for the TestRunner picking up  
should* methods.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

I loaded Phexample 1.0 via Metacello and TestRunner still didn't pick  
shouldXyz methods... Not that that has anything to do with this issue...  
just mentioning...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #15 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

in 2.0 516


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #16 on issue 7367 by [hidden email]: Add support for Phexample to  
Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

Sean:

I put up a configuration in http://ss3.gemstone.com/ss/MetaRepoForPharo20/
and there is a mirror of Phexample on SmalltalkHub with fixes for Pharo 2.0  
(http://smalltalkhub.com/mc/Phexample/Phexample/main)

However, if you look at Phexample class >> allTestSelectors, it  
includes 'should*' methods.
There is also a #isTest: but that doesn't seem to be used anywhere.  
TestCase class seems to define #isUnitTest instead...

Anyway. If I load the config into a fresh pharo image, everything works as  
expected.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #17 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

@Stefan: try this...
1. In Nautilus, browse testArray
2. in the code pane, edit the method name to shouldArray
3. Change the last assert to fail
4. Run the shouldArray test in Nautilus, you will see it fail
5. In the test runner, run the tests in RBParserTest

There will be no failures, seeming that shouldArray was not run


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #18 on issue 7367 by [hidden email]: Add support for Phexample to  
Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

No, indeed... Phexample needs to be the base class of the test.

It is it's own framework, and a test or rather Example needs to
subclass Phexample.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #19 on issue 7367 by [hidden email]: Add support for  
Phexample to Nautilus and cleanup testing for test methods a bit
http://code.google.com/p/pharo/issues/detail?id=7367

Aha! Okay, well in that case, we should patch SUnit like we did Nautilus to  
accept should in general and not tie that to Phexample... "Issue 7459:  
TestRunner should run #shouldXyz methods, like Nautilus"


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker