Issue 7371 in pharo: Archive>>addTree: removingFirstCharacters: match: do not work

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 7371 in pharo: Archive>>addTree: removingFirstCharacters: match: do not work

pharo
Status: New
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 7371 by [hidden email]: Archive>>addTree:  
removingFirstCharacters: match: do not work
http://code.google.com/p/pharo/issues/detail?id=7371

it depends on the method FileDirectory>>slash, not available in pharo2.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7371 in pharo: Archive>>addTree: removingFirstCharacters: match: do not work

pharo
Updates:
        Status: FixReviewNeeded
        Cc: [hidden email]

Comment #1 on issue 7371 by [hidden email]: Archive>>addTree:  
removingFirstCharacters: match: do not work
http://code.google.com/p/pharo/issues/detail?id=7371

Fix in inbox: Compression-SeanDeNigris.121
- Refactor method, replacing send to non-existent #slash; a lot more  
cleaning could be done here

* Beware: I don't know how to test this; I did it all by eye. An executable  
use case would help...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7371 in pharo: Archive>>addTree: removingFirstCharacters: match: do not work

pharo
Updates:
        Status: NoSourcesAvailable

Comment #2 on issue 7371 by [hidden email]: Archive>>addTree:  
removingFirstCharacters: match: do not work
http://code.google.com/p/pharo/issues/detail?id=7371#c2

This Issue has been checked by Ulysse the Monkey, but no sources are  
available

Someone should have a look either to check the validity of the source or to  
report a strange behavior of a crazy monkey.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7371 in pharo: Archive>>addTree: removingFirstCharacters: match: do not work

pharo
Updates:
        Status: FixReviewNeeded

Comment #3 on issue 7371 by [hidden email]: Archive>>addTree:  
removingFirstCharacters: match: do not work
http://code.google.com/p/pharo/issues/detail?id=7371

Forgot the slice :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7371 in pharo: Archive>>addTree: removingFirstCharacters: match: do not work

pharo
Updates:
        Status: MonkeyIsChecking

Comment #4 on issue 7371 by [hidden email]: Archive>>addTree:  
removingFirstCharacters: match: do not work
http://code.google.com/p/pharo/issues/detail?id=7371#c4

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7371 in pharo: Archive>>addTree: removingFirstCharacters: match: do not work

pharo
Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20514

Comment #5 on issue 7371 by [hidden email]: Archive>>addTree:  
removingFirstCharacters: match: do not work
http://code.google.com/p/pharo/issues/detail?id=7371#c5

This Issue has been checked by Ulysse the Monkey
       
6401 tests passed in 00:01:18s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        CompressionTests-Archive (7)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Compression (10)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7371-ArchivegtgtaddTree-removingFirstCharacters-match-do-not-work-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20514-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7371 in pharo: Archive>>addTree: removingFirstCharacters: match: do not work

pharo
Updates:
        Status: MonkeyIsChecking

Comment #6 on issue 7371 by [hidden email]: Archive>>addTree:  
removingFirstCharacters: match: do not work
http://code.google.com/p/pharo/issues/detail?id=7371#c6

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7371 in pharo: Archive>>addTree: removingFirstCharacters: match: do not work

pharo
Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20515

Comment #7 on issue 7371 by [hidden email]: Archive>>addTree:  
removingFirstCharacters: match: do not work
http://code.google.com/p/pharo/issues/detail?id=7371#c7

This Issue has been checked by Ulysse the Monkey
       
6401 tests passed in 00:03:33s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        CompressionTests-Archive (7)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Compression (10)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7371-ArchivegtgtaddTree-removingFirstCharacters-match-do-not-work-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20515-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7371 in pharo: Archive>>addTree: removingFirstCharacters: match: do not work

pharo
Updates:
        Status: HumanReviewNeeded

Comment #8 on issue 7371 by [hidden email]: Archive>>addTree:  
removingFirstCharacters: match: do not work
http://code.google.com/p/pharo/issues/detail?id=7371

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7371 in pharo: Archive>>addTree: removingFirstCharacters: match: do not work

pharo
Updates:
        Status: FixToInclude

Comment #9 on issue 7371 by [hidden email]: Archive>>addTree:  
removingFirstCharacters: match: do not work
http://code.google.com/p/pharo/issues/detail?id=7371

To me this looks all more like dead code... there are no senders.

So lets add this for now


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7371 in pharo: Archive>>addTree: removingFirstCharacters: match: do not work

pharo
Updates:
        Status: Integrated

Comment #10 on issue 7371 by [hidden email]: Archive>>addTree:  
removingFirstCharacters: match: do not work
http://code.google.com/p/pharo/issues/detail?id=7371

in 2.0 517


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7371 in pharo: Archive>>addTree: removingFirstCharacters: match: do not work

pharo
Updates:
        Cc: [hidden email]

Comment #11 on issue 7371 by [hidden email]: Archive>>addTree:  
removingFirstCharacters: match: do not work
http://code.google.com/p/pharo/issues/detail?id=7371

@Marcus: I had the same thought, but I thought maybe it was part of the API  
to manually construct an archive... in either case, I didn't feel like  
investigating it, so I just did the fix...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker