Issue 7372 in pharo: Deadcode

Status: New
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 7372 by [hidden email]: Deadcode
http://code.google.com/p/pharo/issues/detail?id=7372

The following methods depends on FileDirectory, which is not available in  
pharo20:

FileStream>>asURL depends on FileDirectory>>pathParts
MCSubDirectoryRepository>>findFullNameForWriting: depends on  
FileDirectory>>pathParts
ZnMonticelloServerDelegate>>handleGetMczEntry: depends on  
FileDirectory>>fileExists:
ZnMonticelloServerDelegate>>handlePutMczEntry: depends on  
FileDirectory>>fileExists:
Password>>passwordFor: depends on FileDirectory>>isRemoteDirectory


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7372 by [hidden email]: Deadcode
http://code.google.com/p/pharo/issues/detail?id=7372

OK, I will check and fix the ZnMonticelloServerDelegate usage upstream.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Accepted

Comment #2 on issue 7372 by [hidden email]: Deadcode
http://code.google.com/p/pharo/issues/detail?id=7372

Cool :) thanks for the findings.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7372 by [hidden email]: Deadcode
http://code.google.com/p/pharo/issues/detail?id=7372

2 more methods:

FileStream>>asUrl depends on FileDirectory>>pathParts
MCSubDirectoryRepository>>findFullNameForWriting: depends on  
FileDirectory>>pathParts


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Cc: [hidden email] [hidden email]

Comment #4 on issue 7372 by [hidden email]: Deadcode
http://code.google.com/p/pharo/issues/detail?id=7372

I fixed all the non-Zinc ones mentioned (@Sven: do you want another issue  
for the Zn ones, or are you tracking that yourself?). No more senders of  
#isRemoteDirectory or #pathParts in the image.

b.t.w. while we're on Password... WTH is it? Can we nuke it? There are no  
references to it in the image.

Fix in inbox: SLICE-Issue-7372-Deadcode-SeanDeNigris.1
- Fix non-Zinc senders of FileDirectory messages #isRemoteDirectory and  
#pathParts


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 7372 by [hidden email]: Deadcode
http://code.google.com/p/pharo/issues/detail?id=7372

Yes, the Zn ones are already fixed upstream, soon to be integrated


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #6 on issue 7372 by [hidden email]: Deadcode
http://code.google.com/p/pharo/issues/detail?id=7372

in 2.505


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker