Issue 7376 in pharo: Replace MCMethodDefinition's Definitions class variable with a class instance variable

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 7376 in pharo: Replace MCMethodDefinition's Definitions class variable with a class instance variable

pharo
Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Enh

New issue 7376 by [hidden email]: Replace MCMethodDefinition's  
Definitions class variable with a class instance variable
http://code.google.com/p/pharo/issues/detail?id=7376

I'm cherry-picking from Monticello versions in  
http://source.squeak.org/trunk

This one seems good:

Name: Monticello-ul.374
Author: ul
Time: 28 February 2010, 2:57:06.129 pm
UUID: c8779e3f-6e45-2d4a-828e-d6e02cb40546
Ancestors: Monticello-ar.372

- replaced MCMethodDefinition's Definitions class variable with a class  
instance variable. The cached definitions are no longer registered for  
finalization.
- a bit of cleanup around MCDefinition's Instances class variable

Slice comming...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7376 in pharo: Replace MCMethodDefinition's Definitions class variable with a class instance variable

pharo

Comment #1 on issue 7376 by [hidden email]: Replace  
MCMethodDefinition's Definitions class variable with a class instance  
variable
http://code.google.com/p/pharo/issues/detail?id=7376

Slice in inbox. No idea if there was an specific test for this, but at  
least I run (in 20501) all Tests-Monticello and Ring-Tests-Monticello, and  
it's ok: the same two tests have a progress bar ZeroDivide (I don't know if  
there is a issue report for these two guys).


SLICE:

Name:  
SLICE-Issue-7376-Replace-MCMethodDefinitions-Definitions-class-variable-with-a-class-instance-variable-MartinDias.1
Author: MartinDias
Time: 31 January 2013, 4:53:04.577 pm
UUID: 3100f0ba-1eab-4dd2-80cb-3022bd4e317c
Ancestors:
Dependencies: Monticello-MartinDias.748

I'm cherry-picking from Monticello versions in  
http://source.squeak.org/trunk

This one seems good:

Name: Monticello-ul.374
Author: ul
Time: 28 February 2010, 2:57:06.129 pm
UUID: c8779e3f-6e45-2d4a-828e-d6e02cb40546
Ancestors: Monticello-ar.372

- replaced MCMethodDefinition's Definitions class variable with a class  
instance variable. The cached definitions are no longer registered for  
finalization.
- a bit of cleanup around MCDefinition's Instances class variable


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7376 in pharo: Replace MCMethodDefinition's Definitions class variable with a class instance variable

pharo
Updates:
        Status: FixReviewNeeded

Comment #2 on issue 7376 by [hidden email]: Replace  
MCMethodDefinition's Definitions class variable with a class instance  
variable
http://code.google.com/p/pharo/issues/detail?id=7376

I guess I should put this status.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7376 in pharo: Replace MCMethodDefinition's Definitions class variable with a class instance variable

pharo
Updates:
        Labels: -Type-Enh Type-Cleanup

Comment #3 on issue 7376 by [hidden email]: Replace  
MCMethodDefinition's Definitions class variable with a class instance  
variable
http://code.google.com/p/pharo/issues/detail?id=7376

I just discovered that exists "Cleanup" label, better then "Enh" for this  
issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7376 in pharo: Replace MCMethodDefinition's Definitions class variable with a class instance variable

pharo

Comment #4 on issue 7376 by [hidden email]: Replace  
MCMethodDefinition's Definitions class variable with a class instance  
variable
http://code.google.com/p/pharo/issues/detail?id=7376

I have the impression that we should keep it for 3.0 alpha and try to get  
2.0 stable.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7376 in pharo: Replace MCMethodDefinition's Definitions class variable with a class instance variable

pharo
Updates:
        Labels: -Milestone-2.0 Milestone-3.0

Comment #5 on issue 7376 by [hidden email]: Replace  
MCMethodDefinition's Definitions class variable with a class instance  
variable
http://code.google.com/p/pharo/issues/detail?id=7376

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker