Issue 7392 in pharo: completion was not working properly

Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Bug

New issue 7392 by [hidden email]: completion was not working properly
http://code.google.com/p/pharo/issues/detail?id=7392

there where a lot of issues that made it unusable:

- showing packages and other useless information

- not removing selection after "print it", when pressed backspace

- usability options needed were added:
-- enable autopopup,
-- delay configurable,
-- shorcuts for non automatic invocation,
-- space after completion

- settings were broken
- completions window should not be shown when there is no matches anymore,  
except on manual invocation

- added class comments and categorization


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7392 by [hidden email]: completion was not working  
properly
http://code.google.com/p/pharo/issues/detail?id=7392

Issue 7080 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 7392 by [hidden email]: completion was not working  
properly
http://code.google.com/p/pharo/issues/detail?id=7392

Issue 7079 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #3 on issue 7392 by [hidden email]: completion was not working  
properly
http://code.google.com/p/pharo/issues/detail?id=7392

in inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email] [hidden email]
        Labels: -Type-Bug Type-FirstImpressionsCount

Comment #4 on issue 7392 by [hidden email]: completion was not  
working properly
http://code.google.com/p/pharo/issues/detail?id=7392

Wow, just looked at the changes... that looks like a *lot* of work. Thanks  
for taking this on :)

It's so big that I don't know exactly how to review it. Without a list of  
reproducible bugs, I think we'll only find out by putting it into use. But  
I did notice a few things:
- you mentioned removing package names from the completion was part of  
this, but they still appear e.g. in Spotlight
- there is one failing NEC test (that was not failing before the fix) -  
NECUntypedModelTest>>#testCaseSensitivity


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 7392 by [hidden email]: completion was not working  
properly
http://code.google.com/p/pharo/issues/detail?id=7392

yeah, there are still some glitches in the ocompletion algorithm that looks  
for packages... but most of them are out now...
About the yellow test.... yesterday we spend full day with Ben doing this,  
at the end we were so tired that fixing the test was not possible at all :)
I say let's put it on production and next ween we can iterate over the  
errors :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 7392 by [hidden email]: completion was not working  
properly
http://code.google.com/p/pharo/issues/detail?id=7392

...unless ofc you want to take the failing test before :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #7 on issue 7392 by [hidden email]: completion was not  
working properly
http://code.google.com/p/pharo/issues/detail?id=7392

Ha ha... no, I agree. The change is too big to mind f*ck in review. Let's  
throw it out there and fix any bugs we find.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #8 on issue 7392 by [hidden email]: completion was not  
working properly
http://code.google.com/p/pharo/issues/detail?id=7392

in 2.0 507


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker