Issue 7403 in pharo: CMD-click no longer works to activate source-links

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo
Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Type-Bug Target-Morphic Milestone-2.0

New issue 7403 by [hidden email]: CMD-click no longer works to  
activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

CMD-click on a Class/Selector now always triggers the popup menu.
It should only trigger the popup menu on the system's secondary command  
button:

mac: ctrl-click

win: alt-click?
linux: alt-click?

I presume that this came with the latest menu refactorings ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo

Comment #1 on issue 7403 by [hidden email]: CMD-click no longer  
works to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

my first guess must have been wrong, second blame attempt, Rectangle  
refactoring?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo

Comment #2 on issue 7403 by [hidden email]: CMD-click no longer  
works to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

still no... it's deeper that bastard >:(


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo
Updates:
        Cc: [hidden email]

Comment #3 on issue 7403 by [hidden email]: CMD-click no longer  
works to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

ha! first assumption was almost right :P, update 20507 introduced the bug.

the newly added method TextMorph>>#enabled has very strange side-effects.

What is the effect of this method?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo

Comment #4 on issue 7403 by [hidden email]: CMD-click no longer  
works to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

I re-made it work by commenting the following:

ScrollPane>>mouseDown: evt
" evt yellowButtonPressed
                ifTrue: [ (self yellowButtonActivity: evt shiftPressed)
                        ifTrue: [ ^ self ]].
"
        scroller hasSubmorphs ifTrue:
                [scroller submorphs last mouseDown: (evt transformedBy: (scroller  
transformFrom: self))]

but do not understand yet what the problem is...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo

Comment #5 on issue 7403 by [hidden email]: CMD-click no longer  
works to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

and menus still work everywhere?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo

Comment #6 on issue 7403 by [hidden email]: CMD-click no longer  
works to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

On my MBPr 10.8.2, with the above commented out:
- ctrl-click = context menu
- opt-click = halos
- cmd-click = implementors


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo
Updates:
        Status: WorkNeeded-Conclusion

Comment #7 on issue 7403 by [hidden email]: CMD-click no longer  
works to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo

Comment #8 on issue 7403 by [hidden email]: CMD-click no longer  
works to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

What is TextMorph>>#enabled needed for?

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo

Comment #9 on issue 7403 by [hidden email]: CMD-click no longer works  
to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

No idea, but the problem is not un TextMorph>>#enabled, I restored the old  
behavior and problem is still there.
About the check for menu, I would like to test that everything works  
without the check.


--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo

Comment #10 on issue 7403 by [hidden email]: CMD-click no longer works  
to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

of course,

        (evt yellowButtonPressed and: [ evt commandKeyPressed not ]) "First check  
for option (menu) click"
                ifTrue: [ (self yellowButtonActivity: evt shiftPressed)
                        ifTrue: [ ^ self ]].

works too, but just remove the test would be better... as soon as it does  
not break anything else, of course :)

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo

Comment #11 on issue 7403 by [hidden email]: CMD-click no longer  
works to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

nope, removing TextMorph>>#enabled or making it return false works.

but it only works on new text morphs after removing the method.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo
Updates:
        Status: FixReviewNeeded

Comment #12 on issue 7403 by [hidden email]: CMD-click no longer works  
to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

in inbox

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo
Updates:
        Status: FixToInclude

Comment #13 on issue 7403 by [hidden email]: CMD-click no longer works  
to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo

Comment #14 on issue 7403 by [hidden email]: CMD-click no longer works  
to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

I will just fix ScrollPane>>#mouseDown: and hope for the best :)

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo
Updates:
        Status: Integrated

Comment #15 on issue 7403 by [hidden email]: CMD-click no longer works  
to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

in 20554

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo
Updates:
        Status: WorkNeeded

Comment #16 on issue 7403 by [hidden email]: CMD-click no longer  
works to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

not working anymore in 20578

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo
Updates:
        Status: FixReviewNeeded

Comment #17 on issue 7403 by [hidden email]: CMD-click no longer  
works to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

new slice in inbox

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7403 in pharo: CMD-click no longer works to activate source-links

pharo
Updates:
        Status: Integrated

Comment #18 on issue 7403 by [hidden email]: CMD-click no longer  
works to activate source-links
http://code.google.com/p/pharo/issues/detail?id=7403

in 2.0 584

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker