Issue 7424 in pharo: [Bug]: Removing a class does not mark the package as dirty

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 7424 in pharo: [Bug]: Removing a class does not mark the package as dirty

pharo
Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Type-Bug Importance-High Milestone-2.0 Target-Nautilus

New issue 7424 by [hidden email]: [Bug]: Removing a class does not  
mark the package as dirty
http://code.google.com/p/pharo/issues/detail?id=7424

20514

1. In Nautilus, select a class and hit cmd-x, c
2. Open an MC browser

The package from which the class was removed will not be marked dirty

3. Select the package
4. Click "Changes"

The changes will appear.

This is particularly nasty because one of my checks is to check the MC  
browser for dirty packages before deleting an image. This could easily lead  
to lost work.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7424 in pharo: [Bug]: Removing a class does not mark the package as dirty

pharo

Comment #1 on issue 7424 by [hidden email]: [Bug]: Removing a class  
does not mark the package as dirty
http://code.google.com/p/pharo/issues/detail?id=7424

nasty!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7424 in pharo: [Bug]: Removing a class does not mark the package as dirty

pharo

Comment #2 on issue 7424 by [hidden email]: [Bug]: Removing a class  
does not mark the package as dirty
http://code.google.com/p/pharo/issues/detail?id=7424

The vent is triggered, the class removed from the package, then MC asks the  
package if the removed class belongs to it. Of course not (anymore). So no  
dirty ...

Fuuuuuu


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7424 in pharo: [Bug]: Removing a class does not mark the package as dirty

pharo
Updates:
        Status: FixReviewNeeded

Comment #3 on issue 7424 by [hidden email]: [Bug]: Removing a class  
does not mark the package as dirty
http://code.google.com/p/pharo/issues/detail?id=7424

Slice in the inbox

++++++++++++++++++++++++++++++
PostScript:
MCWorkingCopy registerForNotifications
++++++++++++++++++++++++++++++


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7424 in pharo: [Bug]: Removing a class does not mark the package as dirty

pharo
Updates:
        Status: MonkeyIsChecking

Comment #4 on issue 7424 by [hidden email]: [Bug]: Removing a class  
does not mark the package as dirty
http://code.google.com/p/pharo/issues/detail?id=7424#c4

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7424 in pharo: [Bug]: Removing a class does not mark the package as dirty

pharo
Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20517

Comment #5 on issue 7424 by [hidden email]: [Bug]: Removing a class  
does not mark the package as dirty
http://code.google.com/p/pharo/issues/detail?id=7424#c5

This Issue has been checked by Ulysse the Monkey
       
6512 tests passed in 00:01:31s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Monticello (128)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7424-Bug-Removing-a-class-does-not-mark-the-package-as-dirty-BenjaminVanRyseghem.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20517-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7424 in pharo: [Bug]: Removing a class does not mark the package as dirty

pharo
Updates:
        Status: FixToInclude

Comment #6 on issue 7424 by [hidden email]: [Bug]: Removing a class  
does not mark the package as dirty
http://code.google.com/p/pharo/issues/detail?id=7424

It fixes the problem!

N.B. DON'T FORGET THE POST-SCRIPT :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7424 in pharo: [Bug]: Removing a class does not mark the package as dirty

pharo
Updates:
        Status: Integrated

Comment #7 on issue 7424 by [hidden email]: [Bug]: Removing a class  
does not mark the package as dirty
http://code.google.com/p/pharo/issues/detail?id=7424

in 2.0 419


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker