Issue 7435 in pharo: [ENH]: Nautilus: Send unary class-side message from menu

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Type-Enh Milestone-3.0 Difficulty-Easy

New issue 7435 by [hidden email]: [ENH]: Nautilus: Send unary  
class-side message from menu
http://code.google.com/p/pharo/issues/detail?id=7435

Let's remove forever method comments like "self thisMethodSelector" which  
serve no documentation purpose, and are just a hack to make DoIts easier...

Add to: <nautilusGlobalMethodMenu>

        | selectedMethod target |
        target := aBuilder model.
        selectedMethod := target selectedMethod.
        (target selectedClass isMeta and: [ selectedMethod selector isUnary ])  
ifTrue: [
                (aBuilder item: #'Send Message...')
                        action: [ target selectedClass soleInstance perform: selectedMethod  
selector ];
                        order: 0;
                        help: 'Search for a method by name' ].

Maybe short cut "s, m".

Ben, what do you think?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7435 by [hidden email]: [ENH]: Nautilus: Send  
unary class-side message from menu
http://code.google.com/p/pharo/issues/detail?id=7435

Issue 7436 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 7435 by [hidden email]: [ENH]: Nautilus: Send  
unary class-side message from menu
http://code.google.com/p/pharo/issues/detail?id=7435

Issue 7437 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7435 by [hidden email]: [ENH]: Nautilus: Send  
unary class-side message from menu
http://code.google.com/p/pharo/issues/detail?id=7435

"(aBuilder item: #'Send Message...')" should be "(aBuilder item: #'Send  
Message')" (no ellipsis)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 7435 by [hidden email]: [ENH]: Nautilus: Send  
unary class-side message from menu
http://code.google.com/p/pharo/issues/detail?id=7435

Ah, the joys of copy/paste...
"help: 'Search for a method by name'" -> "help: 'Send this unary message to  
the class object'"

And, a check for selectedMethod isNil...

So the new snippet is:

| selectedMethod target |
        target := aBuilder model.
        selectedMethod := target selectedMethod.
        selectedMethod ifNil: [ ^ self ].
        (target selectedClass isMeta and: [ selectedMethod selector isUnary ])  
ifTrue: [
                (aBuilder item: #'Send Message')
                        action: [ target selectedClass soleInstance perform: selectedMethod  
selector ];
                        order: 0;
                        help: 'Send this unary message to the class object' ].


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker