Issue 7468 in pharo: NECCompletion still a bit askew

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Type-Bug

New issue 7468 by [hidden email]: NECCompletion still a bit askew
http://code.google.com/p/pharo/issues/detail?id=7468

If in a workspace I type

Obj
then do shift space to popup the completor, hit enter, it works as expected.

Now, if I am implementing a method,
if I type Obj in a new line, auto complete it, I have a cr inserted  
afterward

If I do it in the middle of a line of code, it autocompletes well, do not  
insert anything, but still put the cursor one character after the end of  
the completed word, with "add space after completion" set to false


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7468 by [hidden email]: NECCompletion still a  
bit askew
http://code.google.com/p/pharo/issues/detail?id=7468

Actually, I think that the cr inserted is nothing more than the character  
skipped.

So both case are the same.

In a nutshell, when you set "insert space after completion" to false, it  
adds nothing, but the cursor is still moved by +1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #2 on issue 7468 by [hidden email]: NECCompletion still a  
bit askew
http://code.google.com/p/pharo/issues/detail?id=7468

Slice in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-2.0

Comment #3 on issue 7468 by [hidden email]: NECCompletion still a  
bit askew
http://code.google.com/p/pharo/issues/detail?id=7468

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #4 on issue 7468 by [hidden email]: NECCompletion still a  
bit askew
http://code.google.com/p/pharo/issues/detail?id=7468#c4

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20531

Comment #5 on issue 7468 by [hidden email]: NECCompletion still a  
bit askew
http://code.google.com/p/pharo/issues/detail?id=7468#c5

This Issue has been checked by Ulysse the Monkey
       
6447 tests passed in 00:01:21s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (592)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (277)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        NECompletion-Tests (63)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7468-NECCompletion-still-a-bit-askew-BenjaminVanRyseghem.1 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20531-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude
        Cc: [hidden email]

Comment #6 on issue 7468 by [hidden email]: NECCompletion still a  
bit askew
http://code.google.com/p/pharo/issues/detail?id=7468

Oh, I see... to get the bug, there has to be a cr to jump e.g. hit enter  
twice, then up arrow, then "Obj" + enter, and the cursor moves...

Fix works


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 7468 by [hidden email]: NECCompletion still a  
bit askew
http://code.google.com/p/pharo/issues/detail?id=7468

in 2.0 532


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker