Issue 7478 in pharo: [BUG]: Empty top level class category creation

Status: Accepted
Owner: [hidden email]
CC: [hidden email],  [hidden email]
Labels: Type-Bug Milestone-2.0 Importance-High

New issue 7478 by [hidden email]: [BUG]: Empty top level class  
category creation
http://code.google.com/p/pharo/issues/detail?id=7478

#20531

Tracked it down to starting with the following update...
20526
-----

Issue 7284: Cannot run gofer load twice => Error: cannot remove non empty  
category
         http://code.google.com/p/pharo/issues/detail?can=2&q=7284

(part 1)

Diff information:
http://ss3.gemstone.com/ss/Pharo20/RPackage-Core-EstebanLorenzano.209.diff


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

(RPackageSet named: 'Spec-Tools') systemCategories.
- includes 'Spec-Tools' in #20526, but not in #20525


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded-NextAction
        Labels: Target-RPackage

Comment #2 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

This doesn't look right to me...
Item was changed:
   ----- Method: RPackageSet>>systemCategories (in category 'system  
compatibility') -----systemCategories
+ ^systemCategories ifNil: [ systemCategories := (self packages collect:  
#packageName) asSet asArray].!
- ^systemCategories ifNil: [ systemCategories := (self  
collectFromAllPackages: #systemCategories) asSet asArray].!

system categories ~= packages. RPackage has a 'Spec-Tools' package, even  
though there is no such system category.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

it was a temporal change (to allow a fix in MC). If it is still there, then  
yes, is a bug :P


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

yep, version 526 was the one with it (to allow me introduce the change in  
527...

if you look current version, it is not there anymore :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

You are right... On to the next culprit...

Item was changed:
   ----- Method: MCPackage>>snapshot (in category 'accessing') -----snapshot
...
+ categories := (packageInfo packages collect: #packageName) asArray.
- categories := packageInfo systemCategories.
...
This is what's causing the packages to appear dirty. Same logic, different  
place. Do we need this for the non-empty package thing?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

yep, that's the line who actually fixes the "cannot remove non-empty  
category" problem (and yes, it took like 5hs of Guille+Me time to figure  
out it :P)




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

Hmmm... well the problem is that system categories ~= packages, so I think  
we need a different fix... hopefully < 5hrs ;-)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

Not sure... MC doesnt need to deal with system categories but packages...  
old PackageInfo had the original problem, because it was returning  
all "Package-" as system categories.
What we did was to return that functionality... using different semantic  
(and probably more correct that before)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

so...?
what about this one?

I still believes my change is correct, and I'd like to close this :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

s/believes/believe


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #11 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

lets close it... (I am starting to get tired...)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded-Conclusion

Comment #12 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

Okay, I just want to make sure that we get this right...

In #20541, if you view changes on the following packages from MC Browser,  
it reports a change because of changes to the package structure, even  
though there has been no change in the underlying structure of those  
packages:
AST-Core
AndreasProfiler
CI-Loader
CodeImport-Tests
Collections-Abstract
Collections-Atomic
Collections-Text
Compression

So, the question is:
- is the list of packages reported now wrong?
- or, was it wrong before, and we're catching the bugs now (so the packages  
will be saved the very next time with the correct structure and we'll be  
done with it)?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

I think it will be saved correctly next time and then it's gone.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #14 on issue 7478 by [hidden email]: [BUG]: Empty top level  
class category creation
http://code.google.com/p/pharo/issues/detail?id=7478

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker