Issue 7634 in pharo: Slow Package Menu on Mouse Button Right Click + Fix

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 7634 in pharo: Slow Package Menu on Mouse Button Right Click + Fix

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-FirstImpressionsCount Milestone-2.0 Target-Nautilus

New issue 7634 by [hidden email]:  Slow Package Menu on Mouse Button  
Right Click + Fix
http://code.google.com/p/pharo/issues/detail?id=7634

Mike Müller writes:


Here is a quick performance fix for Nautilus.

In Pharo2.0a #20581 and previous versions, selecting the package menu with  
my right mouse button lasts too long;
here is why:

95.4% {564ms} NautilusUI(AbstractNautilusUI)>>packageMenuBuilder
   95.4% {564ms} PragmaMenuBuilder class>>withAllPragmaKeywords:model:
     95.4% {564ms} PragmaMenuBuilder>>buildTree
       95.4% {564ms} PragmaMenuBuilder>>collectRegistrations
         90.3% {534ms} CriticBrowser class>>packagesMenu:

Solution, only call CriticsBrowser initialization when this exact menu item  
is selected.

CriticsBrowser>>packagesMenu: aBuilder
<nautilusGlobalPackageMenu>
(aBuilder item: #'Critics Browser')
action: [ | packages target env rules |
target := aBuilder model.
packages := OrderedCollection new.
target selectedPackages do: [:p |  MCWorkingCopy managersForCategory: p  
packageName do: [:package | packages add: package]].
rules :=  RBCompositeLintRule allGoodRules.
env := (RBPackageEnvironment new packages: packages ).
self  openOnRule: rules onEnvironment: env];
help: 'Running critics rules on this package'.


--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7634 in pharo: Slow Package Menu on Mouse Button Right Click + Fix

pharo

Comment #1 on issue 7634 by [hidden email]:  Slow Package Menu on  
Mouse Button Right Click + Fix
http://code.google.com/p/pharo/issues/detail?id=7634

menu generator menthods like this. i.e. the CriticBrowser>packagesGroup:  
can be optimized the same way.

packagesGroup: aBuilder
        <nautilusGlobalGroupMenu>
        (aBuilder item: #'Critics Browser')
                action: [
                                        | packages target env rules group |
                                        target := aBuilder model.
                                        group := target selectedGroups.
                                        packages := OrderedCollection new.
                                        group
                                                do: [ :each | each classes do: [ :cl | MCWorkingCopy  
managersForClass: cl do: [ :package | packages add: package ] ] ].
                                        rules := RBCompositeLintRule allGoodRules.
                                        env := RBPackageEnvironment new packages: packages.
                                        self openOnRule: rules onEnvironment: env ];
                help: 'Running critics rules on this group'


--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7634 in pharo: Slow Package Menu on Mouse Button Right Click + Fix

pharo
Updates:
        Status: WorkNeeded-NextAction

Comment #2 on issue 7634 by [hidden email]:  Slow Package Menu on  
Mouse Button Right Click + Fix
http://code.google.com/p/pharo/issues/detail?id=7634

Next Action: Code in form of a Slice so we can test it...

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7634 in pharo: Slow Package Menu on Mouse Button Right Click + Fix

pharo

Comment #3 on issue 7634 by [hidden email]:  Slow Package Menu on  
Mouse Button Right Click + Fix
http://code.google.com/p/pharo/issues/detail?id=7634

Slice in Inbox

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7634 in pharo: Slow Package Menu on Mouse Button Right Click + Fix

pharo
Updates:
        Status: FixReviewNeeded

Comment #4 on issue 7634 by [hidden email]:  Slow Package Menu on  
Mouse Button Right Click + Fix
http://code.google.com/p/pharo/issues/detail?id=7634

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7634 in pharo: Slow Package Menu on Mouse Button Right Click + Fix

pharo
Updates:
        Status: MonkeyIsChecking

Comment #5 on issue 7634 by [hidden email]:  Slow Package Menu on  
Mouse Button Right Click + Fix
http://code.google.com/p/pharo/issues/detail?id=7634#c5

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7634 in pharo: Slow Package Menu on Mouse Button Right Click + Fix

pharo
Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20582

Comment #6 on issue 7634 by [hidden email]:  Slow Package Menu on  
Mouse Button Right Click + Fix
http://code.google.com/p/pharo/issues/detail?id=7634#c6

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7634 in pharo: Slow Package Menu on Mouse Button Right Click + Fix

pharo
Updates:
        Status: FixToInclude

Comment #7 on issue 7634 by [hidden email]:  Slow Package Menu on  
Mouse Button Right Click + Fix
http://code.google.com/p/pharo/issues/detail?id=7634

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7634 in pharo: Slow Package Menu on Mouse Button Right Click + Fix

pharo
Updates:
        Status: Integrated

Comment #8 on issue 7634 by [hidden email]:  Slow Package Menu on  
Mouse Button Right Click + Fix
http://code.google.com/p/pharo/issues/detail?id=7634

in 2.0 583

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker