Issue 792 in moose-technology: Mondrian - broken popupText:

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 792 by [hidden email]: Mondrian - broken popupText:
http://code.google.com/p/moose-technology/issues/detail?id=792


I have isolated what I assume is an issue introduced in  
ConfigurationOfMondrian-AlexandreBergel.332 with #popupText:

Test Case to execute in Mondrian Easel...
     view interaction popupText: [ :es | 'popupText works'].
     view shape label.
     view node: 'node value'.

With a freshly unzipped Moose_Suite_4_6,
hovering over the node displays a blue box that says 'popupText works'

Using Monticello Browser to load  
ConfigurationOfMondrian-AlexandreBergel.331 then doing '(Smalltalk at:  
#ConfigurationOfMondrian) project lastVersion load'
has the same behaviour.

With Monticello Browser, loading  
ConfigurationOfMondrian-AlexandreBergel.332 then doing '(Smalltalk at:  
#ConfigurationOfMondrian) project lastVersion load'
hovering over the node displays a white box that says 'node value'

This behaviour persists through to current
ConfigurationOfMondrian-AlexandreBergel.348

The comment on 332 is: 2.147 : Pharo ground is seriously shaking those  
days... popupText: does not use the Pharo popup, it instead uses popupView:

Platform: Windows 7


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #1 on issue 792 by [hidden email]: Mondrian - broken  
popupText:
http://code.google.com/p/moose-technology/issues/detail?id=792

MOAnnouncer>>popupView: aBlock delay: ms zoomedInBy: aSymbolOrABlock

aBlock is never used.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #2 on issue 792 by [hidden email]: Mondrian - broken  
popupText:
http://code.google.com/p/moose-technology/issues/detail?id=792

This fixes it for me

MOAnnouncer>>popupText: aBlock delay: ms
     "open a popup text when the mouse enter a node"
     self popupView:
         [ :el :myView |
             myView shape rectangle.
             myView node: 'popup' forIt:
             [   | popupText |
                 popupText := [aBlock value: el ] on: Error do: [ el  
asString ].
                 myView shape label.
                 myView node: popupText
             ].
         ] delay: ms

but I think there is more to it than that. The equivalent from  
version "VeronicaUquillas 7/20/2011 11:07" had the following, but I can't  
get that to work myself...

ifTrue:[ MOPopup show: ([aBlock value: ann element source model value: ann  
element target model ] on: Error do: [ [ (aBlock moValue: ann modelElement)  
asString ] on: Error do: [ 'Error when printing' ] ])  

                                                               
ifFalse:[ MOPopup show: ([ (aBlock moValue: ann modelElement) asString ]  
on: Error do: [ 'Error when printing' ]) asString  ]


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #3 on issue 792 by [hidden email]: Mondrian - broken  
popupText:
http://code.google.com/p/moose-technology/issues/detail?id=792

I have uploaded... Mondrian-Pharo-Morphic-BenComan.34 "Partial fix of  
MOAnnouncer>>popupText: aBlock delay: ms for Issue 792.  "

The use of the temporary variable was for clarity, and might be removed  
upon review - but shouldn't add much delay in terms of human reaction  
time :)

This works as expected displaying for 'node value' for the following...
     view interaction popupText: [ :es | |x| 1/0 ].
     view shape label.
     view node: 'node value'.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Updates:
        Status: Fixed
        Labels: Component-Mondrian Milestone-4.7

Comment #4 on issue 792 by [hidden email]: Mondrian - broken  
popupText:
http://code.google.com/p/moose-technology/issues/detail?id=792

Thanks. I will close the issue.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev