Issue 799 in moose-technology: Editing code in Glamour must be faster

Status: New
Owner: ----
CC: [hidden email]
Labels: Type-Defect Priority-Medium Component-Glamour Milestone-4.7

New issue 799 by [hidden email]: Editing code in Glamour must be  
faster
http://code.google.com/p/moose-technology/issues/detail?id=799

Launch the following browser, and then try to type more code. It is dead  
slow. Using the same fragment in the workspace is fast. This means that we  
are probably using the PluggableTextMorph in a wrong way. The problem  
appeared since Pharo 1.4.

GLMWrapper new
        show: [:a | a text ];
        openOn: 'GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.'

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Updates:
        Status: Accepted

Comment #1 on issue 799 by [hidden email]: Editing code in Glamour  
must be faster
http://code.google.com/p/moose-technology/issues/detail?id=799

(No comment was entered for this change.)

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #2 on issue 799 by [hidden email]: Editing code in Glamour  
must be faster
http://code.google.com/p/moose-technology/issues/detail?id=799

Accepted!

That is a step forward :)

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #3 on issue 799 by [hidden email]: Editing code in Glamour  
must be faster
http://code.google.com/p/moose-technology/issues/detail?id=799

Esteban: any news on this front?

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Updates:
        Labels: -Priority-Medium Priority-High

Comment #4 on issue 799 by [hidden email]: Editing code in Glamour  
must be faster
http://code.google.com/p/moose-technology/issues/detail?id=799

This is an important bug, and I need help to fix it. Does anyone have time  
to look into it?

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #5 on issue 799 by [hidden email]: Editing code in Glamour  
must be faster
http://code.google.com/p/moose-technology/issues/detail?id=799

yeah, sorry... I've been busy like hell :(

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #6 on issue 799 by [hidden email]: Editing code in Glamour  
must be faster
http://code.google.com/p/moose-technology/issues/detail?id=799

The simple text editor seems to be ok now. The problem is in the  
SmalltalkCode

GLMWrapper new
        show: [:a | a smalltalkCode ];
        openOn: 'GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
GLMWatcherWindow uniqueInstance toggleOpen.
'

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #7 on issue 799 by [hidden email]: Editing code in Glamour must  
be faster
http://code.google.com/p/moose-technology/issues/detail?id=799

Observations
- only code, not text. Text stays fast.
- only editing at the end. At the beginning stays fast.
- source code examples in GLMBasicExamples are mostly short enough, so the  
speed drop off seems to be very sudden
- speed loss doesn't seem to be exponential or high O, adding much more  
text just makes it a bit slower
- adding dots at the end of the text stays fast
- changing GLMSmalltalkCodelModel isCodeCompletionAllowed from true to  
false eliminates the lag, but making the text twice as long again  
reintroduces it
- difference between workspace and browser is: workspace remains  
responsive, shows directly the text you're typing, highlighting then  
happens a second later

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Updates:
        Status: Fixed

Comment #8 on issue 799 by [hidden email]: Editing code in Glamour  
must be faster
http://code.google.com/p/moose-technology/issues/detail?id=799

The problem was that PluggableTextMorph was created with autoAccept: true.  
This means that GLMMorphicModel>>accept:notifying: is called on each key  
stroke which completely replaces the text, recompiles it and redoes the  
highlighting twice.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Updates:
        Cc: [hidden email]

Comment #9 on issue 799 by [hidden email]: Editing code in Glamour  
must be faster
http://code.google.com/p/moose-technology/issues/detail?id=799

wow... it was a stupid error (the harder errors to get... )... and I spent  
like 3 days (during 3 months, he, trying to understand the style process  
and why that was happening :)

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #10 on issue 799 by [hidden email]: Editing code in Glamour  
must be faster
http://code.google.com/p/moose-technology/issues/detail?id=799

Well, the reason why we had this code in there was so that we can get a  
hook for getting announced when the text changes inside the morph. We need  
this information so that we can set the text port in the presentation.

So, we fixed the syntax highlighting, but now the text setting is broken.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev