Issue 837 in moose-technology: ROCircle not constrained to equal dimensions

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 837 in moose-technology: ROCircle not constrained to equal dimensions

moose-technology
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 837 by [hidden email]: ROCircle not constrained to  
equal dimensions
http://code.google.com/p/moose-technology/issues/detail?id=837

Currently ROCircle acts more like a hypothetical ROEllipse, since it is not  
constrained to force dimensions to be equal.  The following might be a  
worthwhile test case...
---
| rawView element1 element2 |

element1 := (ROElement on: '1' ).
element1 + ROCircle.
element1  width: 200; height: 100.
self assert: ( element1 height = 200).

element2 := (ROElement on: '2' ).
element2  width: 200; height: 100.
element2 + ROCircle. "Swapped order with above line"
self assert: ( element2 height = 200).  "Should be true.  Currently not."

"optional - following not part of test - just visual feedback"
rawView := ROView new.
rawView add: element1.
rawView add: element2.
ROVerticalLineLayout on: rawView elements.
rawView open.
---

The first assert can be made to work by adding the following...
----
ROCircle>>extent: anExtentPoint
        | max |
        max := anExtentPoint x max: anExtentPoint y.
        extent := max @ max.
        next extent: anExtentPoint
---
The second assert, I'm not sure yet about resolving the fail.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 837 in moose-technology: ROCircle not constrained to equal dimensions

moose-technology

Comment #1 on issue 837 by [hidden email]: ROCircle not constrained  
to equal dimensions
http://code.google.com/p/moose-technology/issues/detail?id=837

This is the first time someone complains about this. I agree about the  
distinction you are making about circle and ellipse.
I've just realized that what cannot be done is to have a circle with the  
same height and width in an element with a different width and height.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 837 in moose-technology: ROCircle not constrained to equal dimensions

moose-technology

Comment #2 on issue 837 by [hidden email]: ROCircle not  
constrained to equal dimensions
http://code.google.com/p/moose-technology/issues/detail?id=837

Less a complaint :) and more a nitpick observation.  You could just change  
it to ROEllipse and be done; or draw a circle within the minimum extent  
dimension; or grow element to equal sides of the maximum dimension as I've  
done above; or just ignore it.
Low priority.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 837 in moose-technology: ROCircle not constrained to equal dimensions

moose-technology
Updates:
        Status: Fixed

Comment #3 on issue 837 by [hidden email]: ROCircle not constrained  
to equal dimensions
http://code.google.com/p/moose-technology/issues/detail?id=837

We now have ROEllipse.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev