Issue 852 in moose-technology: RORubberband with target highlighting

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 852 by [hidden email]: RORubberband with target  
highlighting
http://code.google.com/p/moose-technology/issues/detail?id=852

I have added highlighting of target elements to RORubberband - changeset  
attached. Note changeset is against Roassal-AlexandreBergel.343.mcz  
since .344 breaks something.

Note2, I renamed RORubberbanding to RORubberband.  I had originally been  
tossing up between the two, and under further consideration I think the  
latter is more appropriate.  The former will need to be manually removed.

Attachments:
        RubberBand2.3.cs  5.9 KB

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #1 on issue 852 by [hidden email]: RORubberband with target  
highlighting
http://code.google.com/p/moose-technology/issues/detail?id=852

It appears that the problem with .344 might just be something at my end.  
Downloading moose4.7 just now that includes .344 has no problem.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #2 on issue 852 by [hidden email]: RORubberband with target  
highlighting
http://code.google.com/p/moose-technology/issues/detail?id=852

Tracked the problem down - due to version .344 adding the ivar 'offset' to
ROShorterDistanceAttachPoint and also...
----
ROShorterDistanceAttachPoint>>initialize
     super initialize.
     offset := 0.
----

but ROAbstractLine>>initialize uses 'ROShorterDistanceAttachPoint instance'  
to
get a cached object...
----
ROShorterDistanceAttachPoint >>instance
     instance ifNil: [ instance := self new ].
     ^ instance
----

so the offset ivar of the cached object was 'nil' rather than the  
expected '0',
and fixed with...
ROShorterDistanceAttachPoint resetInstance

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #3 on issue 852 by [hidden email]: RORubberband with target  
highlighting
http://code.google.com/p/moose-technology/issues/detail?id=852

I have updated this to Roassal-BenComan.348 based off latest  
Roassal-AlexandreBergel.345.  It is attached as a mcz since I was having  
trouble using Change Sorter properly.

Renamed RORubberBanding to RORubberBand.
Added target highlighting to RORubberBand.
Added RORemoveEdge.

Attachments:
        Roassal-BenComan.348.mcz  256 KB

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #4 on issue 852 by [hidden email]: RORubberband with target  
highlighting
http://code.google.com/p/moose-technology/issues/detail?id=852

An alternative implementation that exposes more end-user control of actions  
applied to items moving into and out of the target selection (see  
attached .349).

Created ROSelection. Modified RORubberBand and ROExample>>rubberBandOn: to  
use this.  The side-effect is slightly streamlined  
RORubberBand>>initializeElement: and reduced RORubberBand ivars.

Attachments:
        Roassal-BenComan.349.mcz  257 KB

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #5 on issue 852 by [hidden email]: RORubberband with target  
highlighting
http://code.google.com/p/moose-technology/issues/detail?id=852

Some cleanup of RORubberBand that I missed.

Attachments:
        Roassal-AlexandreBergel.346.mcz  257 KB

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #6 on issue 852 by [hidden email]: RORubberband with target  
highlighting
http://code.google.com/p/moose-technology/issues/detail?id=852

Some cleanup of RORubberBand that I missed.

Attachments:
        Roassal-BenComan.350.mcz  257 KB

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Updates:
        Status: Fixed
        Labels: Component-Roassal

Comment #7 on issue 852 by [hidden email]: RORubberband with target  
highlighting
http://code.google.com/p/moose-technology/issues/detail?id=852

In Roassal 1.166. Thanks Ben!

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Updates:
        Labels: Milestone-4.7

Comment #8 on issue 852 by [hidden email]: RORubberband with target  
highlighting
http://code.google.com/p/moose-technology/issues/detail?id=852

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev