Issue 869 in moose-technology: Smalltalk code presentation does not populate the text port

Status: New
Owner: ----
CC: [hidden email]
Labels: Type-Defect Priority-Medium Component-Glamour Milestone-4.7

New issue 869 by [hidden email]: Smalltalk code presentation does not  
populate the text port
http://code.google.com/p/moose-technology/issues/detail?id=869

Typing in the code editor should populate the text port.

The test in  
GLMSmalltalkCodeMorphicTest>>testExplicitAcceptDoesNotAffectTextPort  
captures the problem.

See:  
http://ci.moosetechnology.org/job/moose-latest-dev/lastCompletedBuild/testReport/Glamour.Tests.Morphic/GLMSmalltalkCodeMorphicTest/testExplicitAcceptDoesNotAffectTextPort/

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #1 on issue 869 by [hidden email]: Smalltalk code  
presentation does not populate the text port
http://code.google.com/p/moose-technology/issues/detail?id=869

Adding a changedAction when building the morph seems to fix this problem  
(all tests are green):
         changedAction: [:aText|
                        aText asString trimBoth ifNotEmpty:  [aTextModel text: aText] ];

This should work because PluggableTextMorph>>textChanged triggers this  
action and
is used in the case where we want to listen for live changes in a text  
morph, without triggering
the accept behavior.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #2 on issue 869 by [hidden email]: Smalltalk code  
presentation does not populate the text port
http://code.google.com/p/moose-technology/issues/detail?id=869

Excellent. Funny that we missed this hook until now. This means that we can  
delete the autoAccept: true also from the regular text presentation. Could  
you look into that?

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Comment #3 on issue 869 by [hidden email]: Smalltalk code  
presentation does not populate the text port
http://code.google.com/p/moose-technology/issues/detail?id=869

Done. autoAccept: is no longer used with text presentations.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Updates:
        Status: Fixed

Comment #4 on issue 869 by [hidden email]: Smalltalk code  
presentation does not populate the text port
http://code.google.com/p/moose-technology/issues/detail?id=869

Excellent.

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev