Issue 901 in moose-technology: ROCachedLabel - improved performance with large numbers of elements

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 901 by [hidden email]: ROCachedLabel - improved  
performance with large numbers of elements
http://code.google.com/p/moose-technology/issues/detail?id=901

With large numbers of elements that display strings, Roassal is quite  
slow.  Tracing this down shows the main culprit is #extentFor:.  A proposed  
solution ROCachedLabel is provided in attached .st file which returns a  
cached extentFor value.  This is nilled out when the value of the string  
changes. The other variables in ROCachedLabel are also cached, but the  
performance gain from these is unclear.

To test the effect of this, try the following script for both ROLabel and  
ROCachedLabel...
---
| rawView el count elements |
rawView := ROView new @ RODraggable.
count := 1000.
elements := (1 to: count) collect:
[ :x |
        el := (ROElement spriteOn: x) + ROLabel "ROCachedLabel".
        el on: ROMouseLeftClick do:
        [ :ev |
                ev element model: (ev element model + 1).
                ev element view signalUpdate .
         ]
].
rawView addAll: elements.
1 to: count do:
[ :x |
        rawView add: (ROEdge new from: (elements at: x) to: (elements at: (Random  
new nextInt: count - x + 1))) + ROLine.
].
ROHorizontalTreeLayout on: rawView elements.
rawView open
---

Also attached is the MessageTally report from which it was determined that  
#extentFor was the problem.



Attachments:
        ROCachedLabel.st  1.3 KB
        MessageTally-ROLabel.txt  38.8 KB

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Dear Moose Developer,
I found a reproducable problem with Glamour and TWM

As long as I just load Glamorous the explorer works fine but
after loading the TWM the explorer starts looking like this:


To reproduce, just start anything with a the Glamour development tools
after that load the TilingWindowManager and then you should see the
problem

With best regards
Friedrich



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Updates:
        Status: WontFix
        Labels: Component-Roassal

Comment #1 on issue 901 by [hidden email]: ROCachedLabel - improved  
performance with large numbers of elements
http://code.google.com/p/moose-technology/issues/detail?id=901

Hi Ben,

Your change makes sense. However I do not want to be that hasty to include  
this class in Roassal. The reason is that I prefer to have #extentFor: not  
sent when not necessary than caching it to make it fast. However, if this  
works well in your case, then use it.


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

okay. fair enough.

[hidden email] wrote:
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

It seems something is broken in TWM. I am not using it by default. Would you be interested in investigating it further? It would be good to know.

Cheers,
Doru


On Jan 11, 2013, at 4:19 PM, Friedrich Dominicus <[hidden email]> wrote:

--
www.tudorgirba.com

"There are no old things, there are only old ways of looking at them."




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Tudor Girba <[hidden email]> writes:

> It seems something is broken in TWM. I am not using it by
> default. Would you be interested in investigating it further? It would
> be good to know.
What do you need to know? What can I check to get more information about
it?

Regards
Friedrich
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Tudor Girba <[hidden email]> writes:

> It seems something is broken in TWM. I am not using it by
> default. Would you be interested in investigating it further? It would
> be good to know.
What do you need to know? What can I check to get more information about
it?

Regards
Friedrich
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

My guess is that something in Morphic is somehow different after loading TWM. In particular, you seem to be having problems with MorphTreeMorph.

Is it somehow possible that TWM loads an older version of MorphTreeMorph?

Cheers,
Doru


On Jan 20, 2013, at 5:55 PM, Friedrich Dominicus <[hidden email]> wrote:

--
www.tudorgirba.com

"It's not how it is, it is how we see it."


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev