Issue 941: adding class methods fails

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 941: adding class methods fails

Johan Brichau
Hi,

Adding (new) class methods fails in latest image.
I described the problem and proposed a fix attached to issue 942

----------------------------
Johan Brichau
[hidden email]





_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 941: adding class methods fails

Johan Brichau
that's issue 941 (not 942)

sorry

On 08 Jul 2009, at 00:46, Johan Brichau wrote:

> Hi,
>
> Adding (new) class methods fails in latest image.
> I described the problem and proposed a fix attached to issue 942
>
> ----------------------------
> Johan Brichau
> [hidden email]
>
>
>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

----------------------------
Johan Brichau
[hidden email]





_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 941: adding class methods fails

Stéphane Ducasse
oops!

Stef

On Jul 8, 2009, at 12:47 AM, Johan Brichau wrote:

> that's issue 941 (not 942)
>
> sorry
>
> On 08 Jul 2009, at 00:46, Johan Brichau wrote:
>
>> Hi,
>>
>> Adding (new) class methods fails in latest image.
>> I described the problem and proposed a fix attached to issue 942
>>
>> ----------------------------
>> Johan Brichau
>> [hidden email]
>>
>>
>>
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> ----------------------------
> Johan Brichau
> [hidden email]
>
>
>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 941: adding class methods fails

Stéphane Ducasse
In reply to this post by Johan Brichau
Hi Johan

Lukas fixed OB too. So may be you should load the latest code.

Stef

On Jul 8, 2009, at 12:47 AM, Johan Brichau wrote:

> that's issue 941 (not 942)
>
> sorry
>
> On 08 Jul 2009, at 00:46, Johan Brichau wrote:
>
>> Hi,
>>
>> Adding (new) class methods fails in latest image.
>> I described the problem and proposed a fix attached to issue 942
>>
>> ----------------------------
>> Johan Brichau
>> [hidden email]
>>
>>
>>
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> ----------------------------
> Johan Brichau
> [hidden email]
>
>
>
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 941: adding class methods fails

Lukas Renggli
> Lukas fixed OB too. So may be you should load the latest code.

I did that in the category based browser only, David probably has to
merge these changes into the package browser.

Lukas


>
> Stef
>
> On Jul 8, 2009, at 12:47 AM, Johan Brichau wrote:
>
>> that's issue 941 (not 942)
>>
>> sorry
>>
>> On 08 Jul 2009, at 00:46, Johan Brichau wrote:
>>
>>> Hi,
>>>
>>> Adding (new) class methods fails in latest image.
>>> I described the problem and proposed a fix attached to issue 942
>>>
>>> ----------------------------
>>> Johan Brichau
>>> [hidden email]
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>> ----------------------------
>> Johan Brichau
>> [hidden email]
>>
>>
>>
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>



--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 941: adding class methods fails

David Röthlisberger-2

>> Lukas fixed OB too. So may be you should load the latest code.
>
> I did that in the category based browser only, David probably has to
> merge these changes into the package browser.

ok, I did so.

This means that we do not check for this scary selectors anymore on method compile.

David

>> Stef
>>
>> On Jul 8, 2009, at 12:47 AM, Johan Brichau wrote:
>>
>>> that's issue 941 (not 942)
>>>
>>> sorry
>>>
>>> On 08 Jul 2009, at 00:46, Johan Brichau wrote:
>>>
>>>> Hi,
>>>>
>>>> Adding (new) class methods fails in latest image.
>>>> I described the problem and proposed a fix attached to issue 942
>>>>
>>>> ----------------------------
>>>> Johan Brichau
>>>> [hidden email]
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Pharo-project mailing list
>>>> [hidden email]
>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>> ----------------------------
>>> Johan Brichau
>>> [hidden email]
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>
>
>


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Issue 941: adding class methods fails

Lukas Renggli
>>> Lukas fixed OB too. So may be you should load the latest code.
>>
>> I did that in the category based browser only, David probably has to
>> merge these changes into the package browser.
>
> ok, I did so.
>
> This means that we do not check for this scary selectors anymore on method compile.

Yes, that check is totally useless and extremely annoying, if not in
e-toy mode. Stef and I removed it from the compiler and the old Squeak
browser. As a side-effect when accepting code the parser only runs
once over the source, not twice as it did before.

Cheers,
Lukas

--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project