Issue 946 in moose-technology: MorphTreeMorph truncates labels

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 946 in moose-technology: MorphTreeMorph truncates labels

moose-technology
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium Component-Glamour Milestone-4.8

New issue 946 by [hidden email]: MorphTreeMorph truncates labels
http://code.google.com/p/moose-technology/issues/detail?id=946

Here is how to reproduce:
1. Download a Moose 4.8 image
2. Install the moose fonts and theme:
MooseImageSetupCommandLineHandler new
        installFonts;
        installGLMWhitespaceTheme.
3. Open a GTInspector
Smalltalk explore

You will see that some letters appear on the next row (like sessio + n).


--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 946 in moose-technology: MorphTreeMorph truncates labels

Tudor Girba-2
Hi Alain,

Would have time to look into this issue? I tried to see where the problem comes from but could not find an obvious place.

Cheers,
Doru



On Fri, Jun 7, 2013 at 1:12 PM, <[hidden email]> wrote:
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium Component-Glamour Milestone-4.8

New issue 946 by [hidden email]: MorphTreeMorph truncates labels
http://code.google.com/p/moose-technology/issues/detail?id=946

Here is how to reproduce:
1. Download a Moose 4.8 image
2. Install the moose fonts and theme:
MooseImageSetupCommandLineHandler new
        installFonts;
        installGLMWhitespaceTheme.
3. Open a GTInspector
Smalltalk explore

You will see that some letters appear on the next row (like sessio + n).


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



--

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 946 in moose-technology: MorphTreeMorph truncates labels

Alain Plantec
Hi Doru

I see that the row morph is a wrapped TextMorph.
So, either you force the width so that the text is not wrapped, or, you create a non wrapped TextMorph.
The second solution seems appropriate here: just change the wrapFlag from true to false to fixe this issue.
But, why do you use a TextMorph instead of a StringMorph (much more efficient) ?

GLMTreeMorphNodeModel >> rowMorphForColumn: aGlamourColumn
        ^ (UITheme current
                newTextIn: World
                text: (self containerTree glamourPresentation column: aGlamourColumn valueFor: self item))
                        backgroundColor: self textBackgroundColor;
                        wrapFlag: true;  " set it to false :) "
                        yourself

Cheers
Alain


On 7 juin 2013, at 13:18, Tudor Girba <[hidden email]> wrote:

> Hi Alain,
>
> Would have time to look into this issue? I tried to see where the problem comes from but could not find an obvious place.
>
> Cheers,
> Doru
>
>
>
> On Fri, Jun 7, 2013 at 1:12 PM, <[hidden email]> wrote:
> Status: New
> Owner: ----
> Labels: Type-Defect Priority-Medium Component-Glamour Milestone-4.8
>
> New issue 946 by [hidden email]: MorphTreeMorph truncates labels
> http://code.google.com/p/moose-technology/issues/detail?id=946
>
> Here is how to reproduce:
> 1. Download a Moose 4.8 image
> 2. Install the moose fonts and theme:
> MooseImageSetupCommandLineHandler new
>         installFonts;
>         installGLMWhitespaceTheme.
> 3. Open a GTInspector
> Smalltalk explore
>
> You will see that some letters appear on the next row (like sessio + n).
>
>
> --
> You received this message because this project is configured to send all issue notifications to this address.
> You may adjust your notification preferences at:
> https://code.google.com/hosting/settings
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
>
>
> --
> www.tudorgirba.com
>
> "Every thing has its own flow"


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 946 in moose-technology: MorphTreeMorph truncates labels

moose-technology
In reply to this post by moose-technology
Updates:
        Status: Fixed

Comment #1 on issue 946 by [hidden email]: MorphTreeMorph truncates  
labels
http://code.google.com/p/moose-technology/issues/detail?id=946

Name: Glamour-Morphic-Widgets-TudorGirba.64
Author: TudorGirba
Time: 8 June 2013, 9:46:53.048 pm
UUID: 95c20aaf-7976-4fc8-a55a-3dec49575918
Ancestors: Glamour-Morphic-Widgets-TudorGirba.63

Fixed
Issue 946: MorphTreeMorph truncates labels

Use a simple StringMorph in a list.

Thanks Alain!

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Issue 946 in moose-technology: MorphTreeMorph truncates labels

Tudor Girba-2
In reply to this post by Alain Plantec
Thanks Alain!

I committed the change to only use a simple StringMorph. I do not know what I was thinking :).

Btw, I added you to the Moose team now, and you can commit freely.

Cheers,
Doru


On Jun 7, 2013, at 6:34 PM, Alain Plantec <[hidden email]> wrote:

> Hi Doru
>
> I see that the row morph is a wrapped TextMorph.
> So, either you force the width so that the text is not wrapped, or, you create a non wrapped TextMorph.
> The second solution seems appropriate here: just change the wrapFlag from true to false to fixe this issue.
> But, why do you use a TextMorph instead of a StringMorph (much more efficient) ?
>
> GLMTreeMorphNodeModel >> rowMorphForColumn: aGlamourColumn
> ^ (UITheme current
> newTextIn: World
> text: (self containerTree glamourPresentation column: aGlamourColumn valueFor: self item))
> backgroundColor: self textBackgroundColor;
> wrapFlag: true;  " set it to false :) "
> yourself
>
> Cheers
> Alain
>
>
> On 7 juin 2013, at 13:18, Tudor Girba <[hidden email]> wrote:
>
>> Hi Alain,
>>
>> Would have time to look into this issue? I tried to see where the problem comes from but could not find an obvious place.
>>
>> Cheers,
>> Doru
>>
>>
>>
>> On Fri, Jun 7, 2013 at 1:12 PM, <[hidden email]> wrote:
>> Status: New
>> Owner: ----
>> Labels: Type-Defect Priority-Medium Component-Glamour Milestone-4.8
>>
>> New issue 946 by [hidden email]: MorphTreeMorph truncates labels
>> http://code.google.com/p/moose-technology/issues/detail?id=946
>>
>> Here is how to reproduce:
>> 1. Download a Moose 4.8 image
>> 2. Install the moose fonts and theme:
>> MooseImageSetupCommandLineHandler new
>>        installFonts;
>>        installGLMWhitespaceTheme.
>> 3. Open a GTInspector
>> Smalltalk explore
>>
>> You will see that some letters appear on the next row (like sessio + n).
>>
>>
>> --
>> You received this message because this project is configured to send all issue notifications to this address.
>> You may adjust your notification preferences at:
>> https://code.google.com/hosting/settings
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>>
>>
>> --
>> www.tudorgirba.com
>>
>> "Every thing has its own flow"
>

--
www.tudorgirba.com

"Some battles are better lost than fought."




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev