Issue in WebGrid>setNumbering

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue in WebGrid>setNumbering

Herbert König
Hi,

when using setNumbering in WebGrid, a link is created above the
numbering column.

When clicking this the browser shows "500 Internal Server Error" and
the image shows a MNU.

The reason is in WebGrid>>sortColumnsIfNecessary the (missing) aspect
for the numbering column is performed.

A simple guard clause prevents this but numbering isn't reversed in
this case. I would prefer if the click just where ignored.

What's the preferred solution here?


Cheers,

Herbert                          mailto:[hidden email]
_______________________________________________
Aida mailing list
[hidden email]
http://lists.aidaweb.si/mailman/listinfo/aida

WebGrid-sortColumnsIfNessesary.st (910 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Issue in WebGrid>setNumbering

Janko Mivšek
Hi Herbert,

Herbert König pravi:

> when using setNumbering in WebGrid, a link is created above the
> numbering column.
>
> When clicking this the browser shows "500 Internal Server Error" and
> the image shows a MNU.
>
> The reason is in WebGrid>>sortColumnsIfNecessary the (missing) aspect
> for the numbering column is performed.
>
> A simple guard clause prevents this but numbering isn't reversed in
> this case. I would prefer if the click just where ignored.
>
> What's the preferred solution here?

I just implemented your proposal. Numbering column cannot be sorted anymore.

WebGrid>>sortLinkColumn: aWebGridColumn
  | dummyLink |
  "Cannot sort a column which has an addBlock or is numbered"
  aWebGridColumn hasAddBlock
      ifTrue: [^WebText text: aWebGridColumn name].
  aWebGridColumn isNumbered
      ifTrue: [^WebText text: aWebGridColumn name].
  ...

Thanks for notifying that!

Janko


--
Janko Mivšek
AIDA/Web
Smalltalk Web Application Server
http://www.aidaweb.si

_______________________________________________
Aida mailing list
[hidden email]
http://lists.aidaweb.si/mailman/listinfo/aida
Reply | Threaded
Open this post in threaded view
|

Re: Issue in WebGrid>setNumbering

Nicolas Petton
Le vendredi 13 février 2009 à 21:52 +0100, Janko Mivšek a écrit :

> Hi Herbert,
>
> Herbert König pravi:
>
> > when using setNumbering in WebGrid, a link is created above the
> > numbering column.
> >
> > When clicking this the browser shows "500 Internal Server Error" and
> > the image shows a MNU.
> >
> > The reason is in WebGrid>>sortColumnsIfNecessary the (missing) aspect
> > for the numbering column is performed.
> >
> > A simple guard clause prevents this but numbering isn't reversed in
> > this case. I would prefer if the click just where ignored.
> >
> > What's the preferred solution here?
>
> I just implemented your proposal. Numbering column cannot be sorted anymore.
>
> WebGrid>>sortLinkColumn: aWebGridColumn
>   | dummyLink |
>   "Cannot sort a column which has an addBlock or is numbered"
>   aWebGridColumn hasAddBlock
>       ifTrue: [^WebText text: aWebGridColumn name].
>   aWebGridColumn isNumbered
>       ifTrue: [^WebText text: aWebGridColumn name].
>   ...
>
> Thanks for notifying that!
>
I may be wrong, but I think I already fixed all those bugs with
unsortable columns (not only numbers). At least it should be on the
squeak version.

Cheers!

Nico

> Janko
>
>

_______________________________________________
Aida mailing list
[hidden email]
http://lists.aidaweb.si/mailman/listinfo/aida

signature.asc (204 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Issue in WebGrid>setNumbering

Janko Mivšek
nico pravi:

>>> when using setNumbering in WebGrid, a link is created above the
>>> numbering column.
>>>
>>> When clicking this the browser shows "500 Internal Server Error" and
>>> the image shows a MNU.

>> I just implemented your proposal. Numbering column cannot be sorted anymore.
>> Thanks for notifying that!

> I may be wrong, but I think I already fixed all those bugs with
> unsortable columns (not only numbers). At least it should be on the
> squeak version.

Time for another sync between Squeak and VW Aida therefore :)

Janko
--
Janko Mivšek
AIDA/Web
Smalltalk Web Application Server
http://www.aidaweb.si
_______________________________________________
Aida mailing list
[hidden email]
http://lists.aidaweb.si/mailman/listinfo/aida