Smalltalk › Frameworks & Tools › Seaside › Seaside Development

JQLoad>>onComplete ?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Johan Brichau-2

JQLoad>>onComplete ?

Hi,

I just moved to Seaside 3.0.5 and noticed that the onComplete callback is no longer supported on JQLoad callbacks. It says:

The option ''complete'' is not supported in JQLoad. Either use #ajaxSetup to configure default values, or the more powerful version with #ajax

However, the jQuery documentation still refers to the 'complete' callback function (as opposed to the success callback for get,getjson,getscript, etc...).
I included the simple patch for that in attachment.

Johan

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

JQuery-options-patches.1.cs (329 bytes) Download Attachment

Lukas Renggli

Re: JQLoad>>onComplete ?

Hi Johan,

Thanks for pointing out the issue. The proposed change introduces a
new problem because get/getjson/getscript/load/post do not directly
pass the options to jQuery but only pick some and populate the
positional arguments of the jQuery functions.

Now as far as I understand the docs, get/getJson/getScript/post only
support 'onSuccess' and load only supports 'onComplete'. I committed
JQuery-Core-lr.121 and JQuery-Tests-Core-lr.130 that implement this
behavior. Let me know if this solves the problem for you?

Lukas

--
Lukas Renggli
www.lukas-renggli.ch
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

Johan Brichau-2

Re: JQLoad>>onComplete ?

Hi Lukas,

Oeps... I did not verify my fix indeed...
I just loaded your new update and it works like a charm.

thanks for the swift response!

Johan

On 10 Jul 2011, at 13:21, Lukas Renggli wrote:

> Hi Johan,
>
> Thanks for pointing out the issue. The proposed change introduces a
> new problem because get/getjson/getscript/load/post do not directly
> pass the options to jQuery but only pick some and populate the
> positional arguments of the jQuery functions.
>
> Now as far as I understand the docs, get/getJson/getScript/post only
> support 'onSuccess' and load only supports 'onComplete'. I committed
> JQuery-Core-lr.121 and JQuery-Tests-Core-lr.130 that implement this
> behavior. Let me know if this solves the problem for you?
>
> Lukas
>
> --
> Lukas Renggli
> www.lukas-renggli.ch
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev