> Thanks Alex,
>
> I could manage to isolate the issue. The problem was that MooseQueryResult did not have = defined, and thus, it did not behave like a collection. I added one now, and those tests are green.
>
> However, now we have another failing test that was somehow induced by the newly added = method.
> FAMIXExtensionMetricTest>>testBunchCouplingFAMIXPackage
>
> @Nicolas, could you take a look. There is only one assertion that fails and I just cannot see how the newly added method makes the difference in the bunch computation (I checked: if you remove the method, the bunch test is green again).
>
> Cheers,
> Doru
>
>
> On Apr 5, 2013, at 9:40 PM, Alexandre Bergel <
[hidden email]> wrote:
>
>> Hi!
>>
>> I had a look at the failing tests.
>>
>>> • Moose.Tests.SmalltalkImporter.Core.FamixPropertiesTest.testHasTheSamePropertiesAs
>>
>> I've tried:
>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>> | c model |
>> model := MooseModel new.
>> c := FAMIXClass new.
>> c name: 'C'.
>>
>> model add: c.
>> c hasTheSamePropertiesAs: c. " => false " "Should be true I guess"
>>
>> c allDeclaredProperties detect: [ :each | (each getFrom: c) ~= (each getFrom: c) ] ifNone: [ 'Everything is okay!' ]
>> "=> a FM3PropertyDescription[FAMIX.Type.Provider classes]"
>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>>
>> This FAMIX.Type.Provider classes comes from the following methods:
>>
>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>> FAMIXType>>providerClasses
>> "returns a set of all the classes that the receiver depends on (inherites, staticly accesses, or uses some of their methods)"
>> <MSEProperty: 'Provider classes' type: #FAMIXType> <multivalued>
>>
>> ^ self queryAllOutgoingAssociations atClassScope withoutSelfLoops
>>
>>
>> FAMIXMethod>>providerClasses
>> "returns a set of all the classes that the receiver depends on (inherites, staticly accesses, or uses some of their methods)"
>> <MSEProperty: 'Provider classes' type: #FAMIXType> <multivalued>
>>
>> ^ self queryAllOutgoingAssociations atClassScope withoutSelfLoops
>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>>
>> I guess the annotation should instead be: <MSEProperty: #providerClasses type: #FAMIXType> <multivalued>
>>
>> However the tests are fill yellow (I did not forget to reset the meta description).
>>
>> Doru, Can you see what is wrong? Does this help?
>>
>>
>>> • SmallDude.Tests.Core.DudeMooseSmalltalkTest.testMSEImportExport
>>
>> If we make #testHasTheSamePropertiesAs, then #testMSEImportExport will also be greener. The latter depends on the first.
>>
>> Alexandre
>>>
>>>
>>>
>>> On Apr 5, 2013, at 3:24 AM,
[hidden email] wrote:
>>>
>>>> See <
https://ci.inria.fr/moose/job/moose-latest-dev-4.8/209/>
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>>
[hidden email]
>>>>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev>>>
>>> --
>>> www.tudorgirba.com
>>>
>>> "If you interrupt the barber while he is cutting your hair,
>>> you will end up with a messy haircut."
>>>
>>>
>>> _______________________________________________
>>> Moose-dev mailing list
>>>
[hidden email]
>>>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev>>
>> --
>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>> Alexandre Bergel
http://www.bergel.eu>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>
>>
>>
>
> --
> www.tudorgirba.com
>
> "Sometimes the best solution is not the best solution."
>
Locked
