Latest changes broke Icons

The latest changes on ThemeIcons completely broke functionality and
icons of external and included packages.

1. Intelli J Icons are now used as default, but most icons of
   external packages (Pomodoro, MongoTools, EventRecorder, ScriptManager, ....)
   align with the eclipse icon set. Can we please stay with Eclipse as default
   so that we do not have to introduce intelliJ icons on each external
   project as well?

2. The mechanisms of ThemeIcons class do not work anymore. The icons in  
   Versionner are lost. Also other external package who extended ThemeIcons
   (like DesktopManager) are now broken.
   Just try to load it into a Pharo5.0 Latest update: #50359 now

3. Some of the icons are removed - for instance in catalog and moved to
   be retrieved from Github. But we wanted to componentize the image
   into configs. So the icons of catalog should belong to this project. Right?

4. I can not open the settings in the latest image anymore because the icons
   are tried to retrieve from Github using a HTTPS connection.
   Doesnt work either because I'm on Windows, because of HTTPs, because
   ZnClient does not deal with a firewall correctly.
   It is not good to rely on additional external downloads directly.

I know we want to make progress ... but were such changes discussed on the list
before?

Thx
T.

I've said this before: this can only be developed by someone behind a proxy. Any help would be appreciated. I know it works more or less for plain HTTP, but there are edge cases. There does indeed seem to be a problem with HTTPS, maybe just something small/simple.

That being said, I must say that I do not understand very well how HTTPS proxying might work. I mean, the traffic is by definition encrypted so how can a proxy even do something ? And if there is some way around this, the connection is no longer end-to-end secure. From my point of view, proxies are from last century ;-)

Sven

Hi guys

I think that esteban will have some work to detress from FFI and Spur
hacking :).

Some random thoughts:

- We should have by default icon objects (and not their description and
the objects in the image) in the image
- We should not need to access github to get pharo running :)
-- icon description should be cached on the disc (I was teaching in a
place where there is no internet).
- Icons should probably also delivered modularly (a tool may want to
have specific button).
- Do not push changes like that the friday afternoon :)


Stef

Le 2/10/15 19:40, Torsten Bergmann a écrit :

Hi,

this is an ongoing change. I still need to push two slices :)
Final change will be backward compatible.

What we are doing is eliminating the multiple icon sets from the image… we will have just one, and people will be able to load others if desired, but they *will not* live inside the image (I would like to make the same for themes, but that’s a lot more complicated).
The idea is that people can contribute icons / iconpacks same way linux distros work (ok, we are not as big, but you get the idea).

not really.
we decided the change because eclipse icons do not work at all with dark-theme (and there is no easy way to adopt the svg eclipse icons) So after trying a couple of things, we decided that this iconset works fine in all themes (eclipse maybe do not break existing tools, but you cannot use eclipse with dark theme so many people are outside).
You will still be able to change to eclipse pack if desired.

>
> 2. The mechanisms of ThemeIcons class do not work anymore. The icons in  
>   Versionner are lost. Also other external package who extended ThemeIcons
>   (like DesktopManager) are now broken.
>   Just try to load it into a Pharo5.0 Latest update: #50359 now.

As I say, extension to theme icons will be compatible, just let me finish :)
now… all subclasses will go away so projects will need to adapt (they will need to extend ThemeIcons instead his children).

>  
>
> 3. Some of the icons are removed - for instance in catalog and moved to
>   be retrieved from Github. But we wanted to componentize the image
>   into configs. So the icons of catalog should belong to this project. Right?

more or less… we do not have still a good way to do that.
so, we are adopting something like a “linux desktop” style: we allow icon packs to include icons specific to tools.

for example, nothing is agains having

idea11/eclipse/other
        icons
                overlays
                versionner
                catalog
                etc.

is not perfect, but since is how linux distros work, I think finding a good solution is not so easy (I’m playing with some pragma-based ideas but not sure how to implement them yet…)

>
> 4. I can not open the settings in the latest image anymore because the icons
>   are tried to retrieve from Github using a HTTPS connection.
>   Doesnt work either because I'm on Windows, because of HTTPs, because
>   ZnClient does not deal with a firewall correctly.
>   It is not good to rely on additional external downloads directly.

not that I did not think about :)
in fact you do not need to go out, is just the way I implemented it in settings. If you have icons package in ./icon-packs, they will be load from there,
I will change some stuff then:

- I will not auto-fetch available packs. Instead, I will add a “fetch” button in settings.
- I will make possible to specify urls/directories to fetch.
- I will add a way to do something like that:
       
ThemeIcons new loadFromArchive: aReference; beCurrent.

so anyone can have the iconset they want in their machine and load in startup without going through internet.

>
> I know we want to make progress ... but were such changes discussed on the list
> before?

I think we discussed it but like one-two years ago… just now I got burned by spur and I did this “to relax a bit" :)

I’m sorry if we failed again with communication, sometimes we do not do the movements in right order :(
I will try to enhance that.

Esteban

>
>
> Thx
> T.
>
>
>
>

> On 03 Oct 2015, at 09:35, stepharo <[hidden email]> wrote:
>
> Hi guys
>
> I think that esteban will have some work to detress from FFI and Spur hacking :).
>
> Some random thoughts:
>
> - We should have by default icon objects (and not their description and the objects in the image) in the image

how so?

> - We should not need to access github to get pharo running :)

you DO NOT need it!

> -- icon description should be cached on the disc (I was teaching in a place where there is no internet).

they are cached :)

> - Icons should probably also delivered modularly (a tool may want to have specific button).
> - Do not push changes like that the friday afternoon :)

well… it was yesterday or never. Now I need to finish it, of course :)

Anyone wanting to use the old icons still can do:

ThemeIcons current: EclipseUIThemeIcons new.

(but this will go away, so beware of it)

Esteban

ouch… I meant:
“now, that I did not think about :)"

which is exactly the contrary of what it looks with the typo :)

- We should have by default icon objects (and not their description and the objects in the image) in the image

> how so?
you have them else how can you display them?
I mean the objects = form that represent the bitmap of the icons (vs the
png file)
>> - We should not need to access github to get pharo running :)
> you DO NOT need it!

I know :)
now the icons sets (alternate) should be also packaged with the
distribution because people may not have nice internet connexion.
I should bring you to Togo/Senegal/Algeria/ ... to see what I mean.
>> -- icon description should be cached on the disc (I was teaching in a place where there is no internet).
> they are cached :)
>
>> - Icons should probably also delivered modularly (a tool may want to have specific button).
>> - Do not push changes like that the friday afternoon :)
> well… it was yesterday or never. Now I need to finish it, of course :)

:)

excellent!
>> I know we want to make progress ... but were such changes discussed on the list
>> before?
> I think we discussed it but like one-two years ago… just now I got burned by spur and I did this “to relax a bit" :)
>
> I’m sorry if we failed again with communication, sometimes we do not do the movements in right order :(
> I will try to enhance that.

It should be easy :)

mmm Pharo will come with the default icon set. The other sets are adds that people can use but is not necessary… that’s why we are moving them out image… otherwise, we could have them pre-loaded anyway (inside the image, it would be possible, after all).

if needed and wanted (but I do not think we really need it), we could add those files to the “portable” edition… but as I said, extra icon sets should not be considered part of the pharo distribution.

Esteban

Hi Esteban,

It's broken: "Smalltalk ui icons" now returns an instance of ThemeIconPack instead
of the usual ThemeIcons/subclass.

But most external packages extended ThemeIcons or subclasses with own icons
as this is/was up to the change the default way to do it. It's not possible to
access these extensions anymore using

    Smalltalk ui icons myIcon

now. I understand that you needed a "break" - but it is not fun if you "break" ;)

Bye
T.

Ho Torsten,

No, it is not broken. As I said, is an ongoing change:

https://pharo.fogbugz.com/f/cases/16651

ThemeIconPack is finally renamed as ThemeIcons and all external packages extending it will be able to use.
Now, some thing will not be backward compatibility:

- if you used directly ThemeIcons children
- it you used outside the class some of the private methods (like *IconContents, etc.)
- if you extended ThemeIcons children instead ThemeIcons

they will need to be adapted.
I hope there are not so many because those issues were never recommended anyway :)
(but even if not recommended, I needed to change a lot of miss-uses in some packages… I would like to have a monkey rule to forbid this kinds of integrations into the image :S)

I started this change last friday, in commit 50357… it is tuesday and we are in commit 50366. It’s been just 4 days and 9 builds… (and btw SLICE is not integrated because some weird monkey issues, not because is not ready).
so, please… be patient! ;)

Esteban

On 06-10-15 14:04, Esteban Lorenzano wrote:
> - it you used outside the class some of the private methods (like *IconContents, etc.)

I assume the private - utilities methods will remain?

Stephan

nope
they where “private”,  so why to assume it?

of course, they can be reintroduced, I’m not against it… :)
(but in that case I would not put a misleading “private” as a category :P)

Esteban