Smalltalk › Instantiations

Little usability improvement for Refactoring Browser

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

jtuchel

Little usability improvement for Refactoring Browser

Hi,

here is a short list of things that could make using some of the refactorings in VAST so much nicer and smoother. I guess they all are just a single line of code to change but have a big impact:

If you extract a method you get a prompter that asks for the method name (there are other refactorings where you get the same prompter).

* This prompter has no focus when it opens. The input cursor should be in the method name input field, so that you can just type away.

* The OK button is not the default button. It should.

These two tiny changes would save me two clicks and a second of wondering on each refactoring. Over a day, that's quite some productivity gain! Just type the new name, press Return and I can continue refactoring or working on the improved code a few seconds earlier!

Joachim

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/va-smalltalk.
For more options, visit https://groups.google.com/groups/opt_out.

dmacq

Re: Little usability improvement for Refactoring Browser

Hi Joachim,

I looked at this in the Refactoing Browser and I see Extract Method under Tool. Is this what you are talking about?

I am not an RB expert, so more detail (a use case even!) would be helpful.

Happy New Year to everyone!

Donald [|]

On Monday, December 30, 2013 8:03:38 AM UTC-5, [hidden email] wrote:

Hi,

here is a short list of things that could make using some of the refactorings in VAST so much nicer and smoother. I guess they all are just a single line of code to change but have a big impact:

If you extract a method you get a prompter that asks for the method name (there are other refactorings where you get the same prompter).
* This prompter has no focus when it opens. The input cursor should be in the method name input field, so that you can just type away.
* The OK button is not the default button. It should.

These two tiny changes would save me two clicks and a second of wondering on each refactoring. Over a day, that's quite some productivity gain! Just type the new name, press Return and I can continue refactoring or working on the improved code a few seconds earlier!

Joachim

jtuchel

Re: Little usability improvement for Refactoring Browser

Donald,

that's what I am talking about:

(I use MED RB Extensions, but I guess the prompter is exactly the same in the vanilla RB)

Browse some method in whatever class
Select a piece of code that you'd want to extract to a method
Right click that selection and select "Extract Method -> to self..." from the context menu
You get a prompter that asks for the name of the extracted method

This prompter should set the focus on its entry field and set the OK button as default button.

This fix sure is more a case of finding the place to change than fixing code...

Thanks for looking into this

Joachim

Am Mittwoch, 1. Januar 2014 18:55:56 UTC+1 schrieb Donald MacQueen:

Hi Joachim,

I looked at this in the Refactoing Browser and I see Extract Method under Tool. Is this what you are talking about?

I am not an RB expert, so more detail (a use case even!) would be helpful.

Happy New Year to everyone!

Donald [|]

On Monday, December 30, 2013 8:03:38 AM UTC-5, [hidden email] wrote:
Hi,

here is a short list of things that could make using some of the refactorings in VAST so much nicer and smoother. I guess they all are just a single line of code to change but have a big impact:

If you extract a method you get a prompter that asks for the method name (there are other refactorings where you get the same prompter).
* This prompter has no focus when it opens. The input cursor should be in the method name input field, so that you can just type away.
* The OK button is not the default button. It should.

These two tiny changes would save me two clicks and a second of wondering on each refactoring. Over a day, that's quite some productivity gain! Just type the new name, press Return and I can continue refactoring or working on the improved code a few seconds earlier!

Joachim

jtuchel

Re: Little usability improvement for Refactoring Browser

Hi there,

just for readers' information. I got a file in from Instantiations with a possible fix. So I guess we'll see this improved in the next VAST release. I'll leave it to Instantiations to announce anything.

So there is one of these little things gone that don't seem to matter but make you curse every time you meet them. Refactoring has become even more fun with this little fix because it just works as you expect it.

Joachim

Am Donnerstag, 2. Januar 2014 08:33:17 UTC+1 schrieb [hidden email]:

Donald,

that's what I am talking about:

(I use MED RB Extensions, but I guess the prompter is exactly the same in the vanilla RB)

Browse some method in whatever class
Select a piece of code that you'd want to extract to a method
Right click that selection and select "Extract Method -> to self..." from the context menu
You get a prompter that asks for the name of the extracted method

This prompter should set the focus on its entry field and set the OK button as default button.

This fix sure is more a case of finding the place to change than fixing code...

Thanks for looking into this

Joachim

Am Mittwoch, 1. Januar 2014 18:55:56 UTC+1 schrieb Donald MacQueen:
Hi Joachim,

I looked at this in the Refactoing Browser and I see Extract Method under Tool. Is this what you are talking about?

I am not an RB expert, so more detail (a use case even!) would be helpful.

Happy New Year to everyone!

Donald [|]

On Monday, December 30, 2013 8:03:38 AM UTC-5, [hidden email] wrote:
Hi,

here is a short list of things that could make using some of the refactorings in VAST so much nicer and smoother. I guess they all are just a single line of code to change but have a big impact:

If you extract a method you get a prompter that asks for the method name (there are other refactorings where you get the same prompter).
* This prompter has no focus when it opens. The input cursor should be in the method name input field, so that you can just type away.
* The OK button is not the default button. It should.

These two tiny changes would save me two clicks and a second of wondering on each refactoring. Over a day, that's quite some productivity gain! Just type the new name, press Return and I can continue refactoring or working on the improved code a few seconds earlier!

Joachim

dmacq

Re: Little usability improvement for Refactoring Browser

Attached is the file I sent Joachim which is a new version of the MethodNameDialog class. I don't want him to have all the fun. ;-)

Donald [|]

On Friday, January 3, 2014 9:17:07 AM UTC-5, [hidden email] wrote:

Hi there,

just for readers' information. I got a file in from Instantiations with a possible fix. So I guess we'll see this improved in the next VAST release. I'll leave it to Instantiations to announce anything.
So there is one of these little things gone that don't seem to matter but make you curse every time you meet them. Refactoring has become even more fun with this little fix because it just works as you expect it.

Joachim

Am Donnerstag, 2. Januar 2014 08:33:17 UTC+1 schrieb [hidden email]:
Donald,

that's what I am talking about:

(I use MED RB Extensions, but I guess the prompter is exactly the same in the vanilla RB)

Browse some method in whatever class
Select a piece of code that you'd want to extract to a method
Right click that selection and select "Extract Method -> to self..." from the context menu
You get a prompter that asks for the name of the extracted method

This prompter should set the focus on its entry field and set the OK button as default button.

This fix sure is more a case of finding the place to change than fixing code...

Thanks for looking into this

Joachim

Am Mittwoch, 1. Januar 2014 18:55:56 UTC+1 schrieb Donald MacQueen:
Hi Joachim,

I looked at this in the Refactoing Browser and I see Extract Method under Tool. Is this what you are talking about?

I am not an RB expert, so more detail (a use case even!) would be helpful.

Happy New Year to everyone!

Donald [|]

On Monday, December 30, 2013 8:03:38 AM UTC-5, [hidden email] wrote:
Hi,

here is a short list of things that could make using some of the refactorings in VAST so much nicer and smoother. I guess they all are just a single line of code to change but have a big impact:

If you extract a method you get a prompter that asks for the method name (there are other refactorings where you get the same prompter).
* This prompter has no focus when it opens. The input cursor should be in the method name input field, so that you can just type away.
* The OK button is not the default button. It should.

These two tiny changes would save me two clicks and a second of wondering on each refactoring. Over a day, that's quite some productivity gain! Just type the new name, press Return and I can continue refactoring or working on the improved code a few seconds earlier!

Joachim

MethodNameDialog_53323.st (5K) Download Attachment