Load OB in Pharo 1.2

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
28 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: Load OB in Pharo 1.2

Mariano Martinez Peck


On Tue, Aug 17, 2010 at 8:50 PM, Marcus Denker <[hidden email]> wrote:

On Aug 17, 2010, at 8:28 PM, Lukas Renggli wrote:

> Removing them is cool, but there should be a grace period where they
> are deprecated. Now I had to duplicate the whole class in OB with a
> uniue name.
>
can it be that this class has a var that we pushed up the hierarchy? At least
when I try to load OB in 1.2, I get an error message like that...


Yes, now OB doesn't load in 1.2 because OBPluggableButtonMorph extends from PluggableButtonMorph it seems that now both of them has an instVar called 'enable'.

So...the same problem as Shout loading in 1.2......the simplest solution seems to rename one of the isntVar and once they migrate to 1.2 use the same.

Cheers

Mariano
 

> On Tuesday, August 17, 2010, Gary Chambers <[hidden email]> wrote:
>> Sorry, that was Stef and I at Camp Smalltalk. Did feel good to be rid of XYZPlus classes though ;-)
>>
>> Regards, Gary
>>
>> ----- Original Message ----- From: "Lukas Renggli" <[hidden email]>
>> To: <[hidden email]>
>> Sent: Tuesday, August 17, 2010 7:07 PM
>> Subject: Re: [Pharo-project] Load OB in Pharo 1.2
>>
>>
>> On Tuesday, August 17, 2010, Marcus Denker <[hidden email]> wrote:
>>
>>
>> On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
>>
>>
>> Thanks Lukas. I wasn't who remove that class neither who didn't deprecated.
>> I am just trying to start building Dev images from now...otherwise, we will
>> have to wait a lot of time once the core is released.
>>
>>
>> I think there must be a delay between the release of the core and the
>> non-core images. I don't see how that can otherwise work. Of course it
>> makes sense to have some incremental adaption already upfront ...
>>
>>
>> Hmm... one thing is clear: I want to use Refactoring and especially the
>> Code Critique tool on 1.2. So I need to somehow load it.
>>
>>
>> Yeah that make sense, but I cannot maintain code that I can't use.
>>
>> Lukas
>>
>>
>>
>> (2 pages of philosophical ramblings deleted... I should start a blog..)
>>
>>  Marcus
>>
>>
>> --
>> Marcus Denker -- http://www.marcusdenker.de
>> INRIA Lille -- Nord Europe. Team RMoD.
>>
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>>
>>
>> --
>> Lukas Renggli
>> www.lukas-renggli.ch
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>
>
> --
> Lukas Renggli
> www.lukas-renggli.ch
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

--
Marcus Denker  -- http://www.marcusdenker.de
INRIA Lille -- Nord Europe. Team RMoD.


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Load OB in Pharo 1.2

Lukas Renggli
Well, I just call the variable 'enabledPlus' then :-(

Lukas

On Tuesday, August 17, 2010, Mariano Martinez Peck
<[hidden email]> wrote:

>
>
> On Tue, Aug 17, 2010 at 8:50 PM, Marcus Denker <[hidden email]> wrote:
>
>
> On Aug 17, 2010, at 8:28 PM, Lukas Renggli wrote:
>
>> Removing them is cool, but there should be a grace period where they
>> are deprecated. Now I had to duplicate the whole class in OB with a
>> uniue name.
>>
> can it be that this class has a var that we pushed up the hierarchy? At least
> when I try to load OB in 1.2, I get an error message like that...
>
>
> Yes, now OB doesn't load in 1.2 because OBPluggableButtonMorph extends from PluggableButtonMorph it seems that now both of them has an instVar called 'enable'.
>
> So...the same problem as Shout loading in 1.2......the simplest solution seems to rename one of the isntVar and once they migrate to 1.2 use the same.
>
> Cheers
>
> Mariano
>
>
>
>> On Tuesday, August 17, 2010, Gary Chambers <[hidden email]> wrote:
>>> Sorry, that was Stef and I at Camp Smalltalk. Did feel good to be rid of XYZPlus classes though ;-)
>>>
>>> Regards, Gary
>>>
>>> ----- Original Message ----- From: "Lukas Renggli" <[hidden email]>
>>> To: <[hidden email]>
>>> Sent: Tuesday, August 17, 2010 7:07 PM
>>> Subject: Re: [Pharo-project] Load OB in Pharo 1.2
>>>
>>>
>>> On Tuesday, August 17, 2010, Marcus Denker <[hidden email]> wrote:
>>>
>>>
>>> On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
>>>
>>>
>>> Thanks Lukas. I wasn't who remove that class neither who didn't deprecated.
>>> I am just trying to start building Dev images from now...otherwise, we will
>>> have to wait a lot of time once the core is released.
>>>
>>>
>>> I think there must be a delay between the release of the core and the
>>> non-core images. I don't see how that can otherwise work. Of course it
>>> makes sense to have some incremental adaption already upfront ...
>>>
>>>
>>> Hmm... one thing is clear: I want to use Refactoring and especially the
>>> Code Critique tool on 1.2. So I need to somehow load it.
>>>
>>>
>>> Yeah that make sense, but I cannot maintain code that I can't use.
>>>
>>> Lukas
>>>
>>>
>>>
>>> (2 pages of philosophical ramblings deleted... I should start a blog..)
>>>
>>>  Marcus
>>>
>>>
>>> --
>>> Marcus Denker -- http://www.marcusdenker.de
>>> INRIA Lille -- Nord Europe. Team RMoD.
>>>
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>>
>>>
>>> --
>>> Lukas Renggli
>>> www.lukas-renggli.ch
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>
>> --
>> Lukas Renggli
>> www.lukas-renggli.ch
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> --
> Marcus Denker  -- http://www.marcusdenker.de
> INRIA Lille -- Nord Europe. Team RMoD.
>
>
> _______________________________________________
> Pharo-project mailing list
> Pharo
>

--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Load OB in Pharo 1.2

Lukas Renggli
Or you would keep the empty but deprecated class
PluggableButtonMorphPlus in the image and make everybody happy :-)

On Tuesday, August 17, 2010, Lukas Renggli <[hidden email]> wrote:

> Well, I just call the variable 'enabledPlus' then :-(
>
> Lukas
>
> On Tuesday, August 17, 2010, Mariano Martinez Peck
> <[hidden email]> wrote:
>>
>>
>> On Tue, Aug 17, 2010 at 8:50 PM, Marcus Denker <[hidden email]> wrote:
>>
>>
>> On Aug 17, 2010, at 8:28 PM, Lukas Renggli wrote:
>>
>>> Removing them is cool, but there should be a grace period where they
>>> are deprecated. Now I had to duplicate the whole class in OB with a
>>> uniue name.
>>>
>> can it be that this class has a var that we pushed up the hierarchy? At least
>> when I try to load OB in 1.2, I get an error message like that...
>>
>>
>> Yes, now OB doesn't load in 1.2 because OBPluggableButtonMorph extends from PluggableButtonMorph it seems that now both of them has an instVar called 'enable'.
>>
>> So...the same problem as Shout loading in 1.2......the simplest solution seems to rename one of the isntVar and once they migrate to 1.2 use the same.
>>
>> Cheers
>>
>> Mariano
>>
>>
>>
>>> On Tuesday, August 17, 2010, Gary Chambers <[hidden email]> wrote:
>>>> Sorry, that was Stef and I at Camp Smalltalk. Did feel good to be rid of XYZPlus classes though ;-)
>>>>
>>>> Regards, Gary
>>>>
>>>> ----- Original Message ----- From: "Lukas Renggli" <[hidden email]>
>>>> To: <[hidden email]>
>>>> Sent: Tuesday, August 17, 2010 7:07 PM
>>>> Subject: Re: [Pharo-project] Load OB in Pharo 1.2
>>>>
>>>>
>>>> On Tuesday, August 17, 2010, Marcus Denker <[hidden email]> wrote:
>>>>
>>>>
>>>> On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
>>>>
>>>>
>>>> Thanks Lukas. I wasn't who remove that class neither who didn't deprecated.
>>>> I am just trying to start building Dev images from now...otherwise, we will
>>>> have to wait a lot of time once the core is released.
>>>>
>>>>
>>>> I think there must be a delay between the release of the core and the
>>>> non-core images. I don't see how that can otherwise work. Of course it
>>>> makes sense to have some incremental adaption already upfront ...
>>>>
>>>>
>>>> Hmm... one thing is clear: I want to use Refactoring and especially the
>>>> Code Critique tool on 1.2. So I need to somehow load it.
>>>>
>>>>
>>>> Yeah that make sense, but I cannot maintain code that I can't use.
>>>>
>>>> Lukas
>>>>
>>>>
>>>>
>>>> (2 pages of philosophical ramblings deleted... I should start a blog..)
>>>>
>>>>  Marcus
>>>>
>>>>
>>>> --
>>>> Marcus Denker -- http://www.marcusdenker.de
>>>> INRIA Lille -- Nord Europe. Team RMoD.
>>>>
>>>>
>>>> _______________________________________________
>>>> Pharo-project mailing list
>>>> [hidden email]
>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>>
>>>>
>>>>
>>>> --
>>>> Lukas Renggli
>>>> www.lukas-renggli.ch
>>>>
>>>> _______________________________________________
>>>> Pharo-project mailing list
>>>> [hidden email]
>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>>
>>>> _______________________________________________--
> Lukas Renggli
> www.lukas-renggli.ch
>

--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Load OB in Pharo 1.2

Mariano Martinez Peck
In reply to this post by Lukas Renggli


On Tue, Aug 17, 2010 at 11:12 PM, Lukas Renggli <[hidden email]> wrote:
Well, I just call the variable 'enabledPlus' then :-(


I don't understand....did you do it or not? I don't see the commit...

thanks anyway
 
Lukas

On Tuesday, August 17, 2010, Mariano Martinez Peck
<[hidden email]> wrote:
>
>
> On Tue, Aug 17, 2010 at 8:50 PM, Marcus Denker <[hidden email]> wrote:
>
>
> On Aug 17, 2010, at 8:28 PM, Lukas Renggli wrote:
>
>> Removing them is cool, but there should be a grace period where they
>> are deprecated. Now I had to duplicate the whole class in OB with a
>> uniue name.
>>
> can it be that this class has a var that we pushed up the hierarchy? At least
> when I try to load OB in 1.2, I get an error message like that...
>
>
> Yes, now OB doesn't load in 1.2 because OBPluggableButtonMorph extends from PluggableButtonMorph it seems that now both of them has an instVar called 'enable'.
>
> So...the same problem as Shout loading in 1.2......the simplest solution seems to rename one of the isntVar and once they migrate to 1.2 use the same.
>
> Cheers
>
> Mariano
>
>
>
>> On Tuesday, August 17, 2010, Gary Chambers <[hidden email]> wrote:
>>> Sorry, that was Stef and I at Camp Smalltalk. Did feel good to be rid of XYZPlus classes though ;-)
>>>
>>> Regards, Gary
>>>
>>> ----- Original Message ----- From: "Lukas Renggli" <[hidden email]>
>>> To: <[hidden email]>
>>> Sent: Tuesday, August 17, 2010 7:07 PM
>>> Subject: Re: [Pharo-project] Load OB in Pharo 1.2
>>>
>>>
>>> On Tuesday, August 17, 2010, Marcus Denker <[hidden email]> wrote:
>>>
>>>
>>> On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
>>>
>>>
>>> Thanks Lukas. I wasn't who remove that class neither who didn't deprecated.
>>> I am just trying to start building Dev images from now...otherwise, we will
>>> have to wait a lot of time once the core is released.
>>>
>>>
>>> I think there must be a delay between the release of the core and the
>>> non-core images. I don't see how that can otherwise work. Of course it
>>> makes sense to have some incremental adaption already upfront ...
>>>
>>>
>>> Hmm... one thing is clear: I want to use Refactoring and especially the
>>> Code Critique tool on 1.2. So I need to somehow load it.
>>>
>>>
>>> Yeah that make sense, but I cannot maintain code that I can't use.
>>>
>>> Lukas
>>>
>>>
>>>
>>> (2 pages of philosophical ramblings deleted... I should start a blog..)
>>>
>>>  Marcus
>>>
>>>
>>> --
>>> Marcus Denker -- http://www.marcusdenker.de
>>> INRIA Lille -- Nord Europe. Team RMoD.
>>>
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>>
>>>
>>> --
>>> Lukas Renggli
>>> www.lukas-renggli.ch
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>> _______________________________________________
>>> Pharo-project mailing list
>>> [hidden email]
>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>>>
>>
>> --
>> Lukas Renggli
>> www.lukas-renggli.ch
>>
>> _______________________________________________
>> Pharo-project mailing list
>> [hidden email]
>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> --
> Marcus Denker  -- http://www.marcusdenker.de
> INRIA Lille -- Nord Europe. Team RMoD.
>
>
> _______________________________________________
> Pharo-project mailing list
> Pharo
>

--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Load OB in Pharo 1.2

Marcus Denker-4
In reply to this post by Lukas Renggli

On Aug 17, 2010, at 11:16 PM, Lukas Renggli wrote:

> Or you would keep the empty but deprecated class
> PluggableButtonMorphPlus in the image and make everybody happy :-)
>

Yes, let's do that...

        Marcus

--
Marcus Denker  -- http://www.marcusdenker.de
INRIA Lille -- Nord Europe. Team RMoD.


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Load OB in Pharo 1.2

niko.schwarz
Has this been resolved? I still get an error saying that
PluggableButtonMorphPlus and OBPluggableButtonMorphPlus define
homonymous instance variables.

Niko

On Wed, Aug 18, 2010 at 9:04 AM, Marcus Denker <[hidden email]> wrote:

>
> On Aug 17, 2010, at 11:16 PM, Lukas Renggli wrote:
>
>> Or you would keep the empty but deprecated class
>> PluggableButtonMorphPlus in the image and make everybody happy :-)
>>
>
> Yes, let's do that...
>
>        Marcus
>
> --
> Marcus Denker  -- http://www.marcusdenker.de
> INRIA Lille -- Nord Europe. Team RMoD.
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>



--
http://scg.unibe.ch/staff/Schwarz
twitter.com/nes1983
Tel: +41 076 235 8683

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Load OB in Pharo 1.2

Marcus Denker-4

On Aug 24, 2010, at 7:49 PM, Niko Schwarz wrote:

> Has this been resolved? I still get an error saying that
> PluggableButtonMorphPlus and OBPluggableButtonMorphPlus define
> homonymous instance variables.
>
Works now

Gofer new
       squeaksource: 'rb';
       package: 'AST-Core';
       package: 'AST-Semantic';
       package: 'Refactoring-Core';
       package: 'Refactoring-Spelling';
       load.
Gofer new
      renggli: 'omnibrowser';
      package: 'OmniBrowser';
      package: 'OB-Standard';
      package: 'OB-Morphic';
      package: 'OB-Refactory';
      package: 'OB-Regex';
      load.



--
Marcus Denker  -- http://www.marcusdenker.de
INRIA Lille -- Nord Europe. Team RMoD.


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Load OB in Pharo 1.2

Lukas Renggli
>> Has this been resolved? I still get an error saying that
>> PluggableButtonMorphPlus and OBPluggableButtonMorphPlus define
>> homonymous instance variables.
>>
> Works now
>
> Gofer new
>       squeaksource: 'rb';
>       package: 'AST-Core';
>       package: 'AST-Semantic';
>       package: 'Refactoring-Core';
>       package: 'Refactoring-Spelling';
>       load.
> Gofer new
>      renggli: 'omnibrowser';
>      package: 'OmniBrowser';
>      package: 'OB-Standard';
>      package: 'OB-Morphic';
>      package: 'OB-Refactory';
>      package: 'OB-Regex';
>      load.

No, it has not been resolved. Just don't load the offending packages
Shout and eCompletion and then everything works.

Lukas

--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
12