MASelectionColumn >> renderCellLinkContent:on:

Hi,

In the following method:

MASelectionColumn >> renderCellLinkContent:on:  

I was wondering if this:

html anchor class: (selected isNil ifFalse: [ 'selected' ]);

Shouldn't be rather like this:

html anchor class: (selected ifTrue: [ 'selected' ]);

Note: "selected " is computed as follows:
 selected := self isSelected: anObject.
Which in principal returns a boolean.

Regards,
Reza
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Yes, that looks like a bug. Can you commit the change?

Lukas

On 8 December 2010 21:43, Reza Razavi <[hidden email]> wrote:


--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

At 08:51 09/12/2010, Lukas Renggli wrote:
>Can you commit the change?

Hi Lukas,

Just tried it, but seems authorization is required.

Cheers,
/Reza

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

If you register on source.lukas-renggli.ch, I can add you to the
groups of Magritte and Pier.

Lukas

On 9 December 2010 09:25, Reza Razavi <[hidden email]> wrote:


--
Lukas Renggli
www.lukas-renggli.ch
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

At 09:32 09/12/2010, Lukas Renggli wrote:
>If you register on source.lukas-renggli.ch,

Done.

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

I've added you to the groups.

On 9 December 2010 09:40, Reza Razavi <[hidden email]> wrote:


--
Lukas Renggli
www.lukas-renggli.ch
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

At 09:43 09/12/2010, Lukas Renggli wrote:
>I've added you to the groups.

Thanks Lukas!
The following commit was successful.
/Reza

Name: Magritte-Seaside-razavi_acm_org.343
Author: [hidden email]
Time: 9 December 2010, 10:02:56 am
UUID: 2701011f-d24e-f14a-9e10-512f2500ef16
Ancestors: Magritte-Seaside-lr.342

In this method:

MASelectionColumn >> renderCellLinkContent:on:

changed the following:

html anchor class: (selected isNil ifFalse: [ 'selected' ]);

to:

html anchor class: (selected ifTrue: [ 'selected' ]);


_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki