Smalltalk › Pharo › Pharo Smalltalk Developers

MCGitlabRepository Missing

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

Sean P. DeNigris

MCGitlabRepository Missing

Administrator

Realized this should've been on dev list, not users. Sorry for the cross
post…

An image with build 454 seems still not to have MCGitlabRepository present.
What am I missing?
Same for build 462 with sha 3641442f3ba0613cd9a6428181487ea29e62418c, which
has the package in its source:
https://github.com/pharo-project/pharo/tree/3641442f3ba0613cd9a6428181487ea29e62418c/src/Metacello-Gitlab

Ditto for build 487.sha.58ee23aadcd15e0a969ed675e8141c0cfd95594a

-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

Cheers,
Sean

Marcus Denker-4

Re: MCGitlabRepository Missing

Hi,

The PR was this:

https://github.com/pharo-project/pharo/pull/700/files

It might be that the baseline is not used somehow?

> On 2 Feb 2018, at 04:36, Sean P. DeNigris <[hidden email]> wrote:
>
> Realized this should've been on dev list, not users. Sorry for the cross
> post…
>
> An image with build 454 seems still not to have MCGitlabRepository present.
> What am I missing?
> Same for build 462 with sha 3641442f3ba0613cd9a6428181487ea29e62418c, which
> has the package in its source:
> https://github.com/pharo-project/pharo/tree/3641442f3ba0613cd9a6428181487ea29e62418c/src/Metacello-Gitlab
>
> Ditto for build 487.sha.58ee23aadcd15e0a969ed675e8141c0cfd95594a
>
>
>
> -----
> Cheers,
> Sean
> --
> Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html
>

Pavel Krivanek-3

Re: MCGitlabRepository Missing

The PR was against a wrong branch. The fixed one is being validated.

-- Pavel

2018-02-02 8:17 GMT+01:00 Marcus Denker <[hidden email]>:

> Hi,
>
> The PR was this:
>
> https://github.com/pharo-project/pharo/pull/700/files
>
> It might be that the baseline is not used somehow?
>
>
>> On 2 Feb 2018, at 04:36, Sean P. DeNigris <[hidden email]> wrote:
>>
>> Realized this should've been on dev list, not users. Sorry for the cross
>> post…
>>
>> An image with build 454 seems still not to have MCGitlabRepository present.
>> What am I missing?
>> Same for build 462 with sha 3641442f3ba0613cd9a6428181487ea29e62418c, which
>> has the package in its source:
>> https://github.com/pharo-project/pharo/tree/3641442f3ba0613cd9a6428181487ea29e62418c/src/Metacello-Gitlab
>>
>> Ditto for build 487.sha.58ee23aadcd15e0a969ed675e8141c0cfd95594a
>>
>>
>>
>> -----
>> Cheers,
>> Sean
>> --
>> Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html
>>
>
>

Sean P. DeNigris

Re: MCGitlabRepository Missing

Administrator

Pavel Krivanek-3 wrote
> The PR was against a wrong branch. The fixed one is being validated.

The class has appeared in the latest built image! The only thing left for
this to work is to update Iceberg (dev-0.6 branch) where the other half of
the patch lives :)

-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

Cheers,
Sean