MOViewRenderer>> use of method clone

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

MOViewRenderer>> use of method clone

jannik laval
Hi all,

I try to use Moose in a pharo1.1.

I have a small bug in Mondrian:
It uses the method clone, which is no more defined in pharo1.1,

To resolve the bug, I replace it by copy, but I don't now what are the ripple effects.
With this, I do well a DSM.

Cheers,

---
Jannik Laval


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: MOViewRenderer>> use of method clone

Alexandre Bergel
Well spotted!
All the 233 tests are green. I assume this is ok to replace #clone by  
#copy.

In 393.

Alexandre


On 15 Mar 2010, at 05:54, Laval Jannik wrote:

> Hi all,
>
> I try to use Moose in a pharo1.1.
>
> I have a small bug in Mondrian:
> It uses the method clone, which is no more defined in pharo1.1,
>
> To resolve the bug, I replace it by copy, but I don't now what are  
> the ripple effects.
> With this, I do well a DSM.
>
> Cheers,
>
> ---
> Jannik Laval
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.





_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: MOViewRenderer>> use of method clone

Lukas Renggli
The equivalent of #clone is #shallowCopy. #copy might perform other
actions if #postCopy is implemented, as it does a #shallowCopy
followed by #postCopy.

Lukas

On 15 March 2010 15:23, Alexandre Bergel <[hidden email]> wrote:

> Well spotted!
> All the 233 tests are green. I assume this is ok to replace #clone by #copy.
>
> In 393.
>
> Alexandre
>
>
> On 15 Mar 2010, at 05:54, Laval Jannik wrote:
>
>> Hi all,
>>
>> I try to use Moose in a pharo1.1.
>>
>> I have a small bug in Mondrian:
>> It uses the method clone, which is no more defined in pharo1.1,
>>
>> To resolve the bug, I replace it by copy, but I don't now what are the
>> ripple effects.
>> With this, I do well a DSM.
>>
>> Cheers,
>>
>> ---
>> Jannik Laval
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>



--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: MOViewRenderer>> use of method clone

Alexandre Bergel
Right. Not a big deal in our case.
Fixed in 394.

Alexandre


On 15 Mar 2010, at 09:34, Lukas Renggli wrote:

> The equivalent of #clone is #shallowCopy. #copy might perform other
> actions if #postCopy is implemented, as it does a #shallowCopy
> followed by #postCopy.
>
> Lukas
>
> On 15 March 2010 15:23, Alexandre Bergel <[hidden email]> wrote:
>> Well spotted!
>> All the 233 tests are green. I assume this is ok to replace #clone  
>> by #copy.
>>
>> In 393.
>>
>> Alexandre
>>
>>
>> On 15 Mar 2010, at 05:54, Laval Jannik wrote:
>>
>>> Hi all,
>>>
>>> I try to use Moose in a pharo1.1.
>>>
>>> I have a small bug in Mondrian:
>>> It uses the method clone, which is no more defined in pharo1.1,
>>>
>>> To resolve the bug, I replace it by copy, but I don't now what are  
>>> the
>>> ripple effects.
>>> With this, I do well a DSM.
>>>
>>> Cheers,
>>>
>>> ---
>>> Jannik Laval
>>>
>>>
>>> _______________________________________________
>>> Moose-dev mailing list
>>> [hidden email]
>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>> --
>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>> Alexandre Bergel  http://www.bergel.eu
>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>
>>
>>
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>
>
>
> --
> Lukas Renggli
> http://www.lukas-renggli.ch
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.





_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev