Making OCompletion work in Pharo 1.1

Hi Romain. I was testing a little OCompletion in Pharo 1.1 and I found a bug in ECUntypedModel >> initializeSelectors   as it is doing:

    [ Smalltalk keysDo:
            [ :each |
            selectors add: (ECGlobalEntry
                    contents: each
                    type: #globalVar) ].


Smalltalk, SmalltalkImage and SystemDirectory were refectorized.
Running OCompletion tests, I have one red.

I changed to:

        [ Smalltalk environment keysDo:
            [ :each |
            selectors add: (ECGlobalEntry
                    contents: each
                    type: #globalVar) ].


(notice I added environment)  and with this, the test is green and OCompletion seems to be working.

What do you think? can I commit ?

Cheers

Mariano

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project