Mantis 5669 for trunk

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

Mantis 5669 for trunk

Ken G. Brown
I'd like to suggest that
M5669-Workspace-openFile.2.cs

from http://bugs.squeak.org/bug_view_advanced_page.php?bug_id=5669 get pulled into Squeak 4.2.

It has changes for Kernel-Models, ST80-Controllers, and Tools-Base.
What are the steps necessary to get this changeset applied?

Ken G. Brown

Reply | Threaded
Open this post in threaded view
|

Re: Mantis 5669 for trunk

David T. Lewis
On Tue, Dec 07, 2010 at 03:05:25PM -0700, Ken G. Brown wrote:
> I'd like to suggest that
> M5669-Workspace-openFile.2.cs
>
> from http://bugs.squeak.org/bug_view_advanced_page.php?bug_id=5669 get pulled into Squeak 4.2.
>
> It has changes for Kernel-Models, ST80-Controllers, and Tools-Base.
> What are the steps necessary to get this changeset applied?
>
> Ken G. Brown

Well, basically you would just clean it up and put it in the inbox.
But that's easy to say; I took a quick look at the change set and
I suspect that it may require a bit of effort to tidy it up. The
"bit of a hack" and "odious and may not be airtight" method comments
by the original author are not particularly confidence-inspiring.

Dave


Reply | Threaded
Open this post in threaded view
|

Re: Mantis 5669 for trunk

Ken G. Brown
At 9:13 PM -0500 12/7/10, David T. Lewis apparently wrote:

>On Tue, Dec 07, 2010 at 03:05:25PM -0700, Ken G. Brown wrote:
>> I'd like to suggest that
>> M5669-Workspace-openFile.2.cs
>>
>> from http://bugs.squeak.org/bug_view_advanced_page.php?bug_id=5669 get pulled into Squeak 4.2.
>>
> > It has changes for Kernel-Models, ST80-Controllers, and Tools-Base.
>> What are the steps necessary to get this changeset applied?
>>
>> Ken G. Brown
>
>Well, basically you would just clean it up and put it in the inbox.
>But that's easy to say; I took a quick look at the change set and
>I suspect that it may require a bit of effort to tidy it up. The
>"bit of a hack" and "odious and may not be airtight" method comments
>by the original author are not particularly confidence-inspiring.
>
>Dave

I was wondering whether it would go into the InBox as a changeset, or whether it should be made into a Monticello Package, or whether it should be split into the several MC Packages for which there are changes in the changeset, ie, Kernel-Models, ST80-Controllers, and Tools-Base, and then the separate MC updates posted to the InBox.

Ken

Reply | Threaded
Open this post in threaded view
|

Re: Mantis 5669 for trunk

Chris Muller-3
In reply to this post by Ken G. Brown
I wonder if we could get away with merely registering an additional
FileService to spawn straight from the FileList, if that would satisfy
you Ken?

Incidentally, we do already have a way to open files into a workspace.

  World Menu | open... | file...

But I agree it would be nice to be able to spawn independent windows
from the FileList..

  - Chris

On Tue, Dec 7, 2010 at 4:05 PM, Ken G. Brown <[hidden email]> wrote:

> I'd like to suggest that
> M5669-Workspace-openFile.2.cs
>
> from http://bugs.squeak.org/bug_view_advanced_page.php?bug_id=5669 get pulled into Squeak 4.2.
>
> It has changes for Kernel-Models, ST80-Controllers, and Tools-Base.
> What are the steps necessary to get this changeset applied?
>
> Ken G. Brown
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Mantis 5669 for trunk

Ken G. Brown
At 3:28 PM -0600 12/9/10, Chris Muller apparently wrote:
>I wonder if we could get away with merely registering an additional
>FileService to spawn straight from the FileList, if that would satisfy
>you Ken?

Well in the Workspace menubar menu I'm seeing I'm seeing save contents to file..., but no open. It doesn't make sense to have to go somewhere else to do that.

The issues are discussed in the mantis report.

I would like a convenient way to programmatically save all my Workspaces to text files, then reload them for migration into a new image.

Ken

>Incidentally, we do already have a way to open files into a workspace.
>
>  World Menu | open... | file...
>
>But I agree it would be nice to be able to spawn independent windows
>from the FileList..
>
>  - Chris
>
>On Tue, Dec 7, 2010 at 4:05 PM, Ken G. Brown <[hidden email]> wrote:
>> I'd like to suggest that
>> M5669-Workspace-openFile.2.cs
>>
> > from http://bugs.squeak.org/bug_view_advanced_page.php?bug_id=5669 get pulled into Squeak 4.2.
>>
>> It has changes for Kernel-Models, ST80-Controllers, and Tools-Base.
>> What are the steps necessary to get this changeset applied?
>>
>> Ken G. Brown
>>
>>


Reply | Threaded
Open this post in threaded view
|

Re: Mantis 5669 for trunk

Chris Muller-3
In reply to this post by Chris Muller-3
> Well in the Workspace menubar menu I'm seeing I'm seeing save contents to file..., but no open. It doesn't make sense to have to go somewhere else to do that.

I never saw that before, but the problem with it is it just "dumps"
the text and doesn't assume FileList (model) behavior, where the
workspace is now associated with that file so that, when I press
Command+s, it will save to the file again.  To get that behavior we'd
have to "become" the Workspace to a FileList which is too complicated.

Now that I've seen "save contents to file..." I'd actually like to
remove it; it is totally inconsistent.

A Workspace is supposed to be transient, that's why it does not have
FileList capabilities.

 - Chris



>
> The issues are discussed in the mantis report.
>
> I would like a convenient way to programmatically save all my Workspaces to text files, then reload them for migration into a new image.
>
> Ken
>
>>Incidentally, we do already have a way to open files into a workspace.
>>
>>  World Menu | open... | file...
>>
>>But I agree it would be nice to be able to spawn independent windows
>>from the FileList..
>>
>>  - Chris
>>
>>On Tue, Dec 7, 2010 at 4:05 PM, Ken G. Brown <[hidden email]> wrote:
>>> I'd like to suggest that
>>> M5669-Workspace-openFile.2.cs
>>>
>> > from http://bugs.squeak.org/bug_view_advanced_page.php?bug_id=5669 get pulled into Squeak 4.2.
>>>
>>> It has changes for Kernel-Models, ST80-Controllers, and Tools-Base.
>>> What are the steps necessary to get this changeset applied?
>>>
>>> Ken G. Brown
>>>
>>>
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Mantis 5669 for trunk

Ken G. Brown
I've found ScriptManager <http://www.squeaksource.com/ScriptManager.html> that does some of what I am looking for.
Now next step is getting it to save my data with versions into my local MC repository.

What do you do for saving bits and pieces of misc stuff you want to have in your image when you transition to a new image release?
How do you migrate scripts for customizing the image. eg loading a set of external packages you always want in your dev image?

Thx for any tips,
Ken

At 12:09 PM -0600 12/11/10, Chris Muller apparently wrote:

> > Well in the Workspace menubar menu I'm seeing I'm seeing save contents to file..., but no open. It doesn't make sense to have to go somewhere else to do that.
>
>I never saw that before, but the problem with it is it just "dumps"
>the text and doesn't assume FileList (model) behavior, where the
>workspace is now associated with that file so that, when I press
>Command+s, it will save to the file again.  To get that behavior we'd
>have to "become" the Workspace to a FileList which is too complicated.
>
>Now that I've seen "save contents to file..." I'd actually like to
>remove it; it is totally inconsistent.
>
>A Workspace is supposed to be transient, that's why it does not have
>FileList capabilities.
>
> - Chris
>
>
>
>>
>> The issues are discussed in the mantis report.
>>
>> I would like a convenient way to programmatically save all my Workspaces to text files, then reload them for migration into a new image.
>>
>> Ken
>>
>>>Incidentally, we do already have a way to open files into a workspace.
>>>
>>>  World Menu | open... | file...
>>>
>>>But I agree it would be nice to be able to spawn independent windows
>>>from the FileList..
>>>
>>>  - Chris
>>>
>>>On Tue, Dec 7, 2010 at 4:05 PM, Ken G. Brown <[hidden email]> wrote:
>>>> I'd like to suggest that
>>>> M5669-Workspace-openFile.2.cs
>>>>
>>> > from http://bugs.squeak.org/bug_view_advanced_page.php?bug_id=5669 get pulled into Squeak 4.2.
>>>>
>>>> It has changes for Kernel-Models, ST80-Controllers, and Tools-Base.
>>>> What are the steps necessary to get this changeset applied?
>>>>
>>>> Ken G. Brown
>>>>
>>>>
>>
>>
>>


bpi
Reply | Threaded
Open this post in threaded view
|

Re: Mantis 5669 for trunk

bpi
Hi Ken,

The trick I use since many years is to just use a normal class as a script class, e.g. named MyProjectScripts and put all the scripts as class methods. I use a normal browser for editing. (In VA Smalltalk there is a browser variant on a single class which is slightly more convenient for this.)

This approach has a lot of advantages IMO:
- The scripts are versioned together with the code.
- Persistence is trivial - Monticello.
- Senders and implementers find the script code as well.
- Refactoring works.
- And all this without any special tools.

If I need variables I sometimes use blocks, e.g.

I know a lot of professional Smalltalk programmers who use script classes like that.

Cheers,
Bernhard

Am 11.12.2010 um 19:30 schrieb Ken G. Brown:

> I've found ScriptManager <http://www.squeaksource.com/ScriptManager.html> that does some of what I am looking for.
> Now next step is getting it to save my data with versions into my local MC repository.
>
> What do you do for saving bits and pieces of misc stuff you want to have in your image when you transition to a new image release?
> How do you migrate scripts for customizing the image. eg loading a set of external packages you always want in your dev image?
>
> Thx for any tips,
> Ken

bpi
Reply | Threaded
Open this post in threaded view
|

Re: Mantis 5669 for trunk

bpi
In reply to this post by Ken G. Brown
Hi Ken,

For configuring my images I have a separate package. In each new trunk image I type the following.

Installer cache install: 'BpImageConfiguration'.
BpImageConfiguration configure

The assumption is that the image is in a directory with a package-cache subdirectory which includes the latest mcz for the BpImageConfiguration package. The configure method sets my preferences, configures Monticello repositories and loads code I always want to have, e.g. OCompletion.

Cheers,
Bernhard

Am 11.12.2010 um 19:30 schrieb Ken G. Brown:

> I've found ScriptManager <http://www.squeaksource.com/ScriptManager.html> that does some of what I am looking for.
> Now next step is getting it to save my data with versions into my local MC repository.
>
> What do you do for saving bits and pieces of misc stuff you want to have in your image when you transition to a new image release?
> How do you migrate scripts for customizing the image. eg loading a set of external packages you always want in your dev image?
>
> Thx for any tips,
> Ken

Reply | Threaded
Open this post in threaded view
|

Re: Mantis 5669 for trunk

Ken G. Brown
In reply to this post by bpi
It sound like a decent way to go. I'll be considering this concept.
ScriptManager also does some neat stuff for Workspaces, eg. bringing in, and tearing off.
Might be nice to meld your concept with the way ScriptManager works somehow, get the script storage out into my own package rather than having the Scripts stored in the dictionary in ScriptManager itself.

Thx!
Ken

At 11:20 PM +0100 12/11/10, Bernhard Pieber apparently wrote:

>Hi Ken,
>
>The trick I use since many years is to just use a normal class as a script class, e.g. named MyProjectScripts and put all the scripts as class methods. I use a normal browser for editing. (In VA Smalltalk there is a browser variant on a single class which is slightly more convenient for this.)
>
>This approach has a lot of advantages IMO:
>- The scripts are versioned together with the code.
>- Persistence is trivial - Monticello.
>- Senders and implementers find the script code as well.
>- Refactoring works.
>- And all this without any special tools.
>
>If I need variables I sometimes use blocks, e.g.
>
>I know a lot of professional Smalltalk programmers who use script classes like that.
>
>Cheers,
>Bernhard
>
>Am 11.12.2010 um 19:30 schrieb Ken G. Brown:
>
>> I've found ScriptManager <http://www.squeaksource.com/ScriptManager.html> that does some of what I am looking for.
>> Now next step is getting it to save my data with versions into my local MC repository.
>>
>> What do you do for saving bits and pieces of misc stuff you want to have in your image when you transition to a new image release?
>> How do you migrate scripts for customizing the image. eg loading a set of external packages you always want in your dev image?
>>
>> Thx for any tips,
>> Ken


Reply | Threaded
Open this post in threaded view
|

Re: Mantis 5669 for trunk

Ken G. Brown
In reply to this post by bpi
Any chance I could have a look at your code for examples of how to accomplish all this?

Thx
Ken

At 11:30 PM +0100 12/11/10, Bernhard Pieber apparently wrote:

>Hi Ken,
>
>For configuring my images I have a separate package. In each new trunk image I type the following.
>
>Installer cache install: 'BpImageConfiguration'.
>BpImageConfiguration configure
>
>The assumption is that the image is in a directory with a package-cache subdirectory which includes the latest mcz for the BpImageConfiguration package. The configure method sets my preferences, configures Monticello repositories and loads code I always want to have, e.g. OCompletion.
>
>Cheers,
>Bernhard
>
>Am 11.12.2010 um 19:30 schrieb Ken G. Brown:
>
>> I've found ScriptManager <http://www.squeaksource.com/ScriptManager.html> that does some of what I am looking for.
>> Now next step is getting it to save my data with versions into my local MC repository.
>>
>> What do you do for saving bits and pieces of misc stuff you want to have in your image when you transition to a new image release?
>> How do you migrate scripts for customizing the image. eg loading a set of external packages you always want in your dev image?
>>
>> Thx for any tips,
>> Ken


bpi
Reply | Threaded
Open this post in threaded view
|

Re: Mantis 5669 for trunk

bpi
Have a look at BpImageConfiguration-bp.21.mcz in

MCHttpRepository
        location: 'http://pieber.com/Squeak/mc'
        user: ''
        password: ''

Cheers,
Bernhard

Am 11.12.2010 um 23:37 schrieb Ken G. Brown:

> Any chance I could have a look at your code for examples of how to accomplish all this?
>
> Thx
> Ken
>
> At 11:30 PM +0100 12/11/10, Bernhard Pieber apparently wrote:
>> Hi Ken,
>>
>> For configuring my images I have a separate package. In each new trunk image I type the following.
>>
>> Installer cache install: 'BpImageConfiguration'.
>> BpImageConfiguration configure
>>
>> The assumption is that the image is in a directory with a package-cache subdirectory which includes the latest mcz for the BpImageConfiguration package. The configure method sets my preferences, configures Monticello repositories and loads code I always want to have, e.g. OCompletion.
>>
>> Cheers,
>> Bernhard
>>
>> Am 11.12.2010 um 19:30 schrieb Ken G. Brown:
>>
>>> I've found ScriptManager <http://www.squeaksource.com/ScriptManager.html> that does some of what I am looking for.
>>> Now next step is getting it to save my data with versions into my local MC repository.
>>>
>>> What do you do for saving bits and pieces of misc stuff you want to have in your image when you transition to a new image release?
>>> How do you migrate scripts for customizing the image. eg loading a set of external packages you always want in your dev image?
>>>
>>> Thx for any tips,
>>> Ken
>
>


Reply | Threaded
Open this post in threaded view
|

Re: Mantis 5669 for trunk

Ken G. Brown

Thx!
Ken

At 11:56 PM +0100 12/11/10, Bernhard Pieber apparently wrote:

>Have a look at BpImageConfiguration-bp.21.mcz in
>
>MCHttpRepository
> location: 'http://pieber.com/Squeak/mc'
> user: ''
> password: ''
>
>Cheers,
>Bernhard
>
>Am 11.12.2010 um 23:37 schrieb Ken G. Brown:
>
>> Any chance I could have a look at your code for examples of how to accomplish all this?
>>
>> Thx
>> Ken
>>
>> At 11:30 PM +0100 12/11/10, Bernhard Pieber apparently wrote:
>>> Hi Ken,
>>>
>>> For configuring my images I have a separate package. In each new trunk image I type the following.
>>>
>>> Installer cache install: 'BpImageConfiguration'.
>>> BpImageConfiguration configure
>>>
>>> The assumption is that the image is in a directory with a package-cache subdirectory which includes the latest mcz for the BpImageConfiguration package. The configure method sets my preferences, configures Monticello repositories and loads code I always want to have, e.g. OCompletion.
>>>
>>> Cheers,
>>> Bernhard
>>>
>>> Am 11.12.2010 um 19:30 schrieb Ken G. Brown:
>>>
>>>> I've found ScriptManager <http://www.squeaksource.com/ScriptManager.html> that does some of what I am looking for.
>>>> Now next step is getting it to save my data with versions into my local MC repository.
>>>>
>>>> What do you do for saving bits and pieces of misc stuff you want to have in your image when you transition to a new image release?
>>>> How do you migrate scripts for customizing the image. eg loading a set of external packages you always want in your dev image?
>>>>
>>>> Thx for any tips,
>>>> Ken
>>
>>