Manuscript (Case [Issue]20741) Kernel - SessionManager>>#snapshot:andQuit: should do nothing when the two parameters are false and false.

Classic

List

Threaded

♦

♦

Locked 1 message

Pharo Issue Tracker

Reply | Threaded

Open this post in threaded view

♦

♦

|

Manuscript (Case [Issue]20741) Kernel - SessionManager>>#snapshot:andQuit: should do nothing when the two parameters are false and false.

Julien Delplanque opened Case 20741: SessionManager>>#snapshot:andQuit: should do nothing when the two parameters are false and false. and assigned it to Everyone: Bug in  Kernel: 1. Pharo Image  •  You are subscribed to this case But when you read the code of this method, when you call it with false and false as arguments, it does some actions. I think it should not. I looked at the senders in the image, none of them call it with false and false as arguments. A simple solution is to add a guard boolean expression: (save not and: [ quit not ]) ifTrue: [ ^ self ] Priority: 5 – Fix If Time Status: Work Needed Assigned to: Everyone Milestone: Later Go to Case No longer need updates? Unsubscribe from this case. Don't want Manuscript notifications anymore? Update your preferences. A Manuscript case was opened by Julien Delplanque. Case ID: 20741 Title: SessionManager>>#snapshot:andQuit: should do nothing when the two parameters are false and false. Status: Work Needed Category: Bug Project: Kernel Area: 1. Pharo Image Priority: 5 - Fix If Time Milestone: Later Assigned To: Everyone URL: https://pharo.manuscript.com/f/cases/20741 But when you read the code of this method, when you call it with false and false as arguments, it does some actions. I think it should not. I looked at the senders in the image, none of them call it with false and false as arguments. A simple solution is to add a guard boolean expression: (save not and: [ quit not ]) ifTrue: [ ^ self ] You are subscribed to this case. If you do not want to receive automatic notifications in the future, unsubscribe (https://pharo.manuscript.com/default.asp?pre=preUnsubscribe&pg=pgEditBug&command=view&ixBug=20741) from this case. _______________________________________________ Pharo-bugtracker mailing list [hidden email] https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker