Manuscript (Case [Issue]20811) Spec - TreePresenter selection issue when tree is collapsed

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Manuscript (Case [Issue]20811) Spec - TreePresenter selection issue when tree is collapsed

Pharo Issue Tracker
Manuscript Notification
avatar
Andrew P Black revised a previous entry on Case 20811: TreePresenter selection issue when tree is collapsed:
Bug in Project:  Spec: 1. Pharo Image  •  You are subscribed to this case
The fact that you don't always get the error may indicate that sometimes these objects are Garbage Collected, and sometimes they are not.

I patched this error
m b y making MorphTreeNode>>#selected check for a nil container:

selected: aBoolean
    selected = aBoolean
        ifTrue: [^ self].
    container ifNil: [ ^ self ].
    aBoolean
        ifTrue: [container selectedMorphList add: self]
        ifFalse: [selected 
            ifNotNil: [container selectedMorphList remove: self]].
    selected := aBoolean.

    self complexContents selected: aBoolean

This isn't the real fix, which would to remove the MorphTreeNodeMorph from the SpecTreeNodeModel, so that this method is never invoked.  But this patch should do little harm, since normally container cannot be nil.  It's better than making the user dismiss a walkback!
Priority Priority: 5 – Fix If Time Status Status: Work Needed
Assigned To Assigned to: Everyone Milestone Milestone: Later

Go to Case
No longer need updates? Unsubscribe from this case.

Don't want Manuscript notifications anymore? Update your preferences.

Manuscript

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker