Manuscript (Case [Issue]21612) Usability - Performances regression on source code search

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Manuscript (Case [Issue]21612) Usability - Performances regression on source code search

Pharo Issue Tracker
Manuscript Notification
avatar
Bug in Project:  Usability: Misc  •  You are subscribed to this case
<code>
SourceFile>>#tryOpenReadOnly: readOnly
| basename |
basename := path asFileReference basename.

"Open a read write stream only if read only access was not requested"
readOnly ifFalse: [
potentialLocations
do: [ :each |
[ stream := ZnCharacterReadWriteStream
bufferedOn: (File named: (each asFileReference / basename) fullName) writeStream
encoding: 'utf8'.
^ self ] on: Error do: [ ] ] ].

potentialLocations do: [ :each |
[ stream := ZnCharacterReadStream
on: (ZnBufferedReadStream on: (File named: (each asFileReference / basename) fullName) readStream)
encoding: 'utf8'.
^ self ] on: Error do: [ ] ]
</code>

<code>
ZnCharacterReadWriteStream class>>#bufferedOn: wrappedStream encoding: encoding

^ self new
bufferedOn: wrappedStream encoding: encoding;
yourself
</code>

<code>
ZnCharacterReadWriteStream>>#bufferedOn: aStream encoding: encoding
| encoder |
encoder := encoding asZnCharacterEncoder.
readStream := ZnCharacterReadStream on: (ZnBufferedReadStream on: aStream) encoding: encoder.
writeStream := ZnCharacterWriteStream on: (ZnBufferedWriteStream on: aStream) encoding: encoder
</code>

The Zn changes have to be take upstream as well.
Priority Priority: 2 – Really Important Status Status: Work Needed
Assigned To Assigned to: Everyone Milestone Milestone: Pharo7.0

Go to Case
No longer need updates? Unsubscribe from this case.

Don't want Manuscript notifications anymore? Update your preferences.

Manuscript

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker