Pharo Issue Tracker - Manuscript (Case [Issue]21644) Tools - RBRefersToClassRule gives misleading advice for class methods

Manuscript Notification

	Marcus Denker resolved Case 21644: RBRefersToClassRule gives misleading advice for class methods and assigned it to Martin Walk: Bug in Tools: 1. Pharo Image • You are subscribed to this case

I added in the description that it can be either self class or self.

This smell arises when a class has its class name directly in the source instead of "self class" (or just "self" when on the class side). The self class / self variant allows you to create subclasses without needing to redefine that method.
However we cannot systematically replace Class reference by self class or self because a Class reference is static and a self expression is dynamic. So the programmer may want to send messages to root of an hierarchy and not to the leaf classes. Therefore this rule generates false positives, please double check when fixing!

https://github.com/pharo-project/pharo/pull/1380

Status changed:
Work Needed

Resolved (Fix Review Needed)

Assigned To changed:
Everyone

Martin Walk

Milestone changed:
Later

Pharo7.0

	Priority: 5 – Fix If Time		Status: Resolved (Fix Review Needed)
	Assigned to: Martin Walk		Milestone: Pharo7.0

Go to Case

No longer need updates? Unsubscribe from this case.

Don't want Manuscript notifications anymore? Update your preferences.

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker