Pharo Issue Tracker - Manuscript (Case [Issue]22250) SmallLint - RBCascadeNextPutAllsRule refactoring crash BlueInk

Manuscript Notification

	CyrilFerlicot edited Case 22250: RBCascadeNextPutAllsRule refactoring crash BlueInk: Bug in SmallLint: 1. Pharo Image • You are subscribed to this case

In Pharo 6 this critic did a rewrite of the method using RBParseTreeRewriter. This one managed the case where the refactored node was contained in a cascade or not.

In Pharo 7 the rewrite is done in ReReplaceNodeCritique. But this one uses a becomeForward: to replace an old node by a rewritten node. But this breaks in case the new node cannot just replace the old one, like when it tries to introduce a cascade in another cascade.

I don't know renraku enough to fix the problem and I was wondering why ReReplaceNodeCritique does the replacement itself when we already have RBParseTreeNode?

Anyway, it's probably too complex to fix for Pharo 7. Moving to Pharo 8.

Milestone changed:
Pharo7.0

Pharo8.0

	Priority: 3 – Must Fix		Status: Work Needed
	Assigned to: Everyone		Milestone: Pharo8.0

Go to Case

No longer need updates? Unsubscribe from this case.

Don't want Manuscript notifications anymore? Update your preferences.

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker