Manuscript (Case [Issue]22255) Collection - Either Pragma should compare methodSelector or PragmaCollector should account for bad comparison

Classic

List

Threaded

♦

♦

Locked 1 message

Pharo Issue Tracker

Reply | Threaded

Open this post in threaded view

♦

♦

|

Manuscript (Case [Issue]22255) Collection - Either Pragma should compare methodSelector or PragmaCollector should account for bad comparison

Peter Uhnák opened Case 22255: Either Pragma should compare methodSelector or PragmaCollector should account for bad comparison and assigned it to Everyone: Bug in  Collection: 1. Pharo Image  •  You are subscribed to this case Part of Pragma comparison (Pragma>>#=) compares its containing method, however CompiledMethods do not compare selector. Therefore PragmaCollector can sometimes add duplicate entries or remove incorrect ones when a different method was removed. Comparison failure example: <code> cls := Object subclass: #Something. cls compile: 'first <broken> ^ 1'. cls compile: 'second <broken> ^ 1'. pragmas := Pragma allNamed: #broken in: cls. pragmas. "an Array(<broken> <broken>)" pragmas asSet. "a Set(<broken>)" cls methods. "{Something>>#first. Something>>#second}" cls methods asSet. "a Set(Something>>#first)" (cls>>#first) = (cls>>#second) "true" </code> PragmaCollector failure example: <code> cls := Object subclass: #Something. cls compile: 'first <broken> ^ 1'. cls compile: 'second <broken> ^ 1'. collector := PragmaCollector filter: [ :prg | (#(broken) includes: prg keyword) ]. collector reset. collector collected collect: #methodSelector. "an OrderedCollection(#first #second)" cls removeSelector: #second. collector collected collect: #methodSelector. "an OrderedCollection(#second)" </code> Priority: 3 – Must Fix Status: Work Needed Assigned to: Everyone Milestone: Pharo7.0 Go to Case No longer need updates? Unsubscribe from this case. Don't want Manuscript notifications anymore? Update your preferences. A Manuscript case was opened by Peter Uhnák. Case ID: 22255 Title: Either Pragma should compare methodSelector or PragmaCollector should account for bad comparison Status: Work Needed Category: Bug Project: Collection Area: 1. Pharo Image Priority: 3 - Must Fix Milestone: Pharo7.0: 9/2/2018 Assigned To: Everyone URL: https://pharo.manuscript.com/f/cases/22255 Part of Pragma comparison (Pragma>>#=) compares its containing method, however CompiledMethods do not compare selector. Therefore PragmaCollector can sometimes add duplicate entries or remove incorrect ones when a different method was removed. Comparison failure example: <code> cls := Object subclass: #Something. cls compile: 'first <broken> ^ 1'. cls compile: 'second <broken> ^ 1'. pragmas := Pragma allNamed: #broken in: cls. pragmas. "an Array(<broken> <broken>)" pragmas asSet. "a Set(<broken>)" cls methods. "{Something>>#first. Something>>#second}" cls methods asSet. "a Set(Something>>#first)" (cls>>#first) = (cls>>#second) "true" </code> PragmaCollector failure example: <code> cls := Object subclass: #Something. cls compile: 'first <broken> ^ 1'. cls compile: 'second <broken> ^ 1'. collector := PragmaCollector filter: [ :prg | (#(broken) includes: prg keyword) ]. collector reset. collector collected collect: #methodSelector. "an OrderedCollection(#first #second)" cls removeSelector: #second. collector collected collect: #methodSelector. "an OrderedCollection(#second)" </code> You are subscribed to this case. If you do not want to receive automatic notifications in the future, unsubscribe (https://pharo.manuscript.com/default.asp?pre=preUnsubscribe&pg=pgEditBug&command=view&ixBug=22255) from this case. _______________________________________________ Pharo-bugtracker mailing list [hidden email] https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker