Manuscript (Case [Issue]22308) _Inbox - Cleaning baseClass/classClass leftovers

Stephane Ducasse edited Case 22308: Cleaning baseClass/classClass leftovers: Cleanup in  _Inbox: Not Spam  •  You are subscribed to this case I have the impression that my changes breaks senders/implementors in findSelectorFromAST Now the logic of findSelectorFromAST is really bad since the client has no way to know that the fallbackBlock has been sent. findSelectorFromAST "Try to make a selector out of the current text selection" | node fallbackBlock | fallbackBlock := [^self]. node := self bestNodeInTextAreaOnError: fallbackBlock. node isMethod ifFalse: [ (node isValue and: [ node value isSymbol ]) ifTrue: [ ^node value ]. [ node isMessage ] whileFalse: [ (node := node parent) ifNil: fallbackBlock ]]. ^node selector Priority: 5 – Fix If Time Status: Work Needed Assigned to: Everyone Milestone: Pharo7.0 Go to Case No longer need updates? Unsubscribe from this case. Don't want Manuscript notifications anymore? Update your preferences.

A Manuscript case was edited by Stephane Ducasse. Case ID: 22308 Title: Cleaning baseClass/classClass leftovers Status: Work Needed Category: Cleanup Project: _Inbox Area: Not Spam Priority: 5 - Fix If Time Milestone: Pharo7.0: 9/2/2018 Assigned To: Everyone URL: https://pharo.manuscript.com/f/cases/22308 I have the impression that my changes breaks senders/implementors in findSelectorFromAST Now the logic of findSelectorFromAST is really bad since the client has no way to know that the fallbackBlock has been sent. findSelectorFromAST "Try to make a selector out of the current text selection" | node fallbackBlock | fallbackBlock := [^self]. node := self bestNodeInTextAreaOnError: fallbackBlock. node isMethod ifFalse: [ (node isValue and: [ node value isSymbol ]) ifTrue: [ ^node value ]. [ node isMessage ] whileFalse: [ (node := node parent) ifNil: fallbackBlock ]]. ^node selector You are subscribed to this case. If you do not want to receive automatic notifications in the future, unsubscribe (https://pharo.manuscript.com/default.asp?pre=preUnsubscribe&pg=pgEditBug&command=view&ixBug=22308) from this case.
_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker