Manuscript (Case [Issue]22309) _Inbox - findSelectorFromAST implementation sucks!

Stephane Ducasse opened Case 22309: findSelectorFromAST implementation sucks! and assigned it to Everyone: Bug in  _Inbox: Not Spam  •  You are subscribed to this case When the fallbackBlock is executed.... a Rub object is returned instead of something else. This use of block is bad!!! It is like an exception but a silent one. So a bug nest findSelectorFromAST "Try to make a selector out of the current text selection" | node fallbackBlock | fallbackBlock := [^self]. node := self bestNodeInTextAreaOnError: fallbackBlock. node isMethod ifFalse: [ (node isValue and: [ node value isSymbol ]) ifTrue: [ ^node value ]. [ node isMessage ] whileFalse: [ (node := node parent) ifNil: fallbackBlock ]]. ^node selector Let us look at the senders implementorsOfIt "Open an implementors browser on the selected selector" | aSelector | "self lineSelectAndEmptyCheck: [^ self]." (aSelector := self selectedSelector) ifNil: [^ textArea flash]. self implementorsOf: aSelector Bingo!!! just check for nil! Bad to me Priority: 5 – Fix If Time Status: Work Needed Assigned to: Everyone Milestone: Later Go to Case No longer need updates? Unsubscribe from this case. Don't want Manuscript notifications anymore? Update your preferences.

A Manuscript case was opened by Stephane Ducasse. Case ID: 22309 Title: findSelectorFromAST implementation sucks! Status: Work Needed Category: Bug Project: _Inbox Area: Not Spam Priority: 5 - Fix If Time Milestone: Later Assigned To: Everyone URL: https://pharo.manuscript.com/f/cases/22309 When the fallbackBlock is executed.... a Rub object is returned instead of something else. This use of block is bad!!! It is like an exception but a silent one. So a bug nest findSelectorFromAST "Try to make a selector out of the current text selection" | node fallbackBlock | fallbackBlock := [^self]. node := self bestNodeInTextAreaOnError: fallbackBlock. node isMethod ifFalse: [ (node isValue and: [ node value isSymbol ]) ifTrue: [ ^node value ]. [ node isMessage ] whileFalse: [ (node := node parent) ifNil: fallbackBlock ]]. ^node selector Let us look at the senders implementorsOfIt "Open an implementors browser on the selected selector" | aSelector | "self lineSelectAndEmptyCheck: [^ self]." (aSelector := self selectedSelector) ifNil: [^ textArea flash]. self implementorsOf: aSelector Bingo!!! just check for nil! Bad to me You are subscribed to this case. If you do not want to receive automatic notifications in the future, unsubscribe (https://pharo.manuscript.com/default.asp?pre=preUnsubscribe&pg=pgEditBug&command=view&ixBug=22309) from this case.
_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker