Pharo Issue Tracker - Manuscript (Case [Issue]22477) Kernel - DelayScheduler cleanup and refactoring

Manuscript Notification

	Ben Coman revised a previous entry on Case 22477: DelayScheduler cleanup and refactoring: Cleanup in Kernel: 1. Pharo Image • You are subscribed to this case

Thanks for your review Max. I'm guilty of not actually running the DelayTests, just the tests I'd written for DelayBasicSchedulerTest.

Your point-1 is correct and fixed. Refining your point-2, its not so much scheduledDelayIsNil wait needs to go after calling the super method, but needs to be slotted it into the middle of the super method as shown in this commit.

I like your first two points of "Other notes" and they are done in this commit.

Your last point I strongly disagree with :) While #forMutualExclusion technically do the same thing, DelaySemaphoreScheduler does not use mutual exclusion and using that method confuses the semantics. (Mutual exclusion defines the #wait & #signal to be performed by the same process, which is not the case. This is a signalling between separate produce/consumer processes). I've been sitting on the fence about doing a particular refactoring, and now I will do it. I think it will help so I've done that as a final commit, now pending further review .

	Priority: 3 – Must Fix		Status: Resolved (Fix Review Needed)
	Assigned to: Ben Coman		Milestone: Later

Go to Case

No longer need updates? Unsubscribe from this case.

Don't want Manuscript notifications anymore? Update your preferences.

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
https://lists.gforge.inria.fr/mailman/listinfo/pharo-bugtracker